[vim/vim] Improve test_codestyle whitespace testing (PR #18599)
dkearns
Problem: test_codestyle does not catch all intended whitespace violations in help files.
Solution: Improve the relevant patterns.
- Don't require a character
[^/]before<SPACE><TAB>so we can match this at the start of a line. - Add a specific test exception for
:help 12.7. - Fix the pattern test for the exception at
:help 27.6, this was matching the pattern/[^? ^I]/rather than the literal text and skipping most of the file.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18599
Commit Summary
- 5c27006 Improve test_codestyle whitespace testing
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
@h-east approved this pull request.
Thanks for fixing my elementary mistake of using a double quote string on the right hand side of the regular expression match.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns pushed 1 commit.
- 144d35d Improve test_codestyle whitespace testing
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#18599)It might be better to explicitly match the existing exceptions for the trailing whitespace test (/\~\s\+$/ and /\\\s\+$/), as there's only six matches in total, and simplify the general pattern to /\s\+$/?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
