[vim/vim] GTK4: Fix draw area sizing in form widget (PR #20486)
Foxe Chen
Currently the size request of the draw area is not explicitly set in gui_mch_set_text_area_pos(). Problem is that when the window is resized or the overall layout of the window changes, the form widget is the one that will receive a new size allocation, which will then handle its children (draw area, scrollbars). This means drawarea_resize_cb() is redundant and will cause a resize loop when using vim_form_move_resize() in gui_mch_set_text_area_pos() (which it should).
Before:
image.png (view on web)
After:
image.png (view on web)
This pretty much reverts #20327
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20486
Commit Summary
- b95f360 fix text area sizing in form widget for gtk4 gui
File Changes
(4 files)
- M src/gui.c (8)
- M src/gui_gtk4.c (109)
- M src/gui_gtk4_f.c (9)
- M src/proto/gui_gtk4.pro (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20486)@stevefalco can you check if this PR causes any issues for you (since it removed most of the code from the PR that fixed your issue). Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.