[vim/vim] Add -Wstrict-prototypes -Wmissing-prototypes warnings check to CI (PR #13223)
Yee Cheng Chin
Add two new warnings to CI:
-
strict-prototypeshelps prevent declaring a function with an empty argument list, e.g.int func(). In C++, that's equivalent toint func(void), but in C, that means a function that can take any number of arguments which is rarely what we want. -
missing-prototypesmakes sure we usestaticfor file-only internal functions. Non-static functions should have been declared on a prototype file.
Also, fix up misc code warnings that this found.
GTK header needs to have #pragma warning suppressiong because GTK2 headers will warn on -Wstrict-prototypes, and it's included by gui.h and so we can't just turn off the warning in a couple files.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/13223
Commit Summary
- 7442f1d Add -Wstrict-prototypes -Wmissing-prototypes warnings check to CI
File Changes
(8 files)
- M ci/config.mk.sed (4)
- M src/gui.h (3)
- M src/if_perl.xs (2)
- M src/if_py_both.h (8)
- M src/if_python3.c (6)
- M src/if_tcl.c (2)
- M src/option.c (4)
- M src/optionstr.c (6)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yee Cheng Chin
I mentioned in #13166, but I think we should just add these warnings to be checked in CI.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
thanks, let me squash in #13226 as well into this
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.