[vim/vim] Cannot map Ctrl-I in terminal mode when using modifyOtherKeys (PR #16558)
zeertzjq
Problem: Cannot map Ctrl-I in terminal mode when using modifyOtherKeys
(after 9.0.0912).
Solution: Convert letters with Ctrl modifier to upper-case in input
buffer, and convert them back to lower-case in libvterm.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/16558
Commit Summary
- d3ef1a8 Cannot map Ctrl-I in terminal mode when using modifyOtherKeys
File Changes
(2 files)
- M src/libvterm/src/keyboard.c (10)
- M src/misc2.c (10)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq pushed 1 commit.
- 0dd2367 Cannot map Ctrl-I in terminal mode when using modifyOtherKeys
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
I've been trying hours to write a test for this, but it has always been extremely flaky.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
I'm not entirely sure about this PR. If (hypothetically) there is a terminal that sends Ctrl-i and Ctrl-I (both without Shift modifier) for two different key combinations, this PR will make Vim treat these two as the same. However Vim already treats these two as the same in non-Terminal mode, so maybe this still makes sense.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
Oh, that can actually happen in XTerm when Caps Lock is on. This may need more consideration then.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Oh, that can actually happen in XTerm when Caps Lock is on. This may need more consideration then.
Oh, it doesn't send Shift-modifier even with xterm-modifier keys enabled?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
If you mean modifyOtherKeys level 2, when Caps Lock is active, Ctrl-I sends \x1b[27;5;73~, which doesn't include the Shift modifier. In comparison, when Caps Lock is off, Ctrl-Shift-I sends \x1b[27;6;73~, which includes the Shift modifier.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#16558)this has stalled, so closing
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.