[vim/vim] Fix Test_clientserver_x11_registry_loose_name() failing on X11 (PR #21333)

3 views

Skip to first unread message

Ying Dong

unread,

Sep 17, 2026, 12:33:12 PM (6 days ago) Sep 17

to vim/vim, Subscribed

Problem

Test_clientserver_x11_registry_loose_name(), added in patch 9.2.1113, asserts that its
--remote-send succeeds:

  " Loose match: "XVIMTESTREG" against a registered "XVIMTESTREG1" whose
  " window id is not hex.
  call system(cmd .. ' --servername ' .. name .. ' --remote-send x')
  call assert_equal(0, v:shell_error)

That send failing is the point of the test. The xprop call above it replaces the whole
VimRegistry property with one entry whose window id is zz, which unregisters the server the
test started, so the send finds nothing, reports E247 and exits 1. On a display where the test
runs, the assertion fails every time:

Found errors in Test_clientserver_x11_registry_loose_name():
line 31: Expected 0 but got 1
Flaky test failed too often, giving up

CI does not see it. Every X11 test in test_clientserver.vim is skipped there —
Check_X11_Connection() calls CheckX11(), which refuses a display when $WAYLAND_DISPLAY is
set, and both ci-linux.yml and ci-linux_asan.yml set it. In the run for 9.2.1113, all six
report SKIPPED …: not pure X11 environment, Test_client_server() included; the Windows and
macOS jobs skip on x11 feature missing. So the failure only shows up for someone running the
suite on a plain X11 session.

Solution

Drop the assertion. The test deliberately asserts nothing — it walks the path so a sanitizer
build notices a regression — and this line asserts the opposite of what the path does.

Sorry: the test is mine, from #21320, and the assertion is the one line of it I did not write, so
I should have re-run the merged version before it landed rather than only what I submitted.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/21333

Commit Summary

627b0dd patch 9.2.xxxx: test_clientserver fails on a pure X11 display

File Changes

(1 file)

M src/testdir/test_clientserver.vim (1)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Sep 17, 2026, 3:08:43 PM (5 days ago) Sep 17

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#21333)

Ah thanks. Yes I added the assert, because I thought we wouldn't see the ASAN failure from ASAN.