[vim/vim] Fix changed_lines arguments in blockwise paste (PR #19844)

[Pierluigi Lenoci]

Summary

When doing a blockwise paste beyond the end of the buffer, changed_lines() is called with an incorrect lnume argument. The third argument curwin->w_cursor.lnum includes the newly appended lines, but lnume should be "the first line below the changed lines BEFORE the change."

This fix subtracts nr_lines (the number of appended lines) from curwin->w_cursor.lnum, as suggested by @brammool in #6660.

Port of neovim/neovim#12733. Fixes #6660.

Changes

• src/register.c: Fix the third argument to changed_lines() in blockwise paste from curwin->w_cursor.lnum to curwin->w_cursor.lnum - nr_lines
• src/testdir/test_listener.vim: Add Test_listener_blockwise_paste() to verify the listener receives correct start, end, and added values when doing a blockwise paste that appends lines beyond the buffer end

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19844

Commit Summary

• 7026824 Fix changed_lines arguments in blockwise paste

File Changes

(2 files)

• M src/register.c (2)
• M src/testdir/test_listener.vim (19)

Patch Links:

• https://github.com/vim/vim/pull/19844.patch
• https://github.com/vim/vim/pull/19844.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19844)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/c4143545123@github.com>

[Christian Brabandt]

Closed #19844 via 80a0c35.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/issue_event/23977222056@github.com>

[Pierluigi Lenoci]

pierluigilenoci left a comment (vim/vim#19844)

@chrisbra, why thanks and then close it?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/c4144168486@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19844)

Because I merged it

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/c4144204628@github.com>

[Pierluigi Lenoci]

pierluigilenoci left a comment (vim/vim#19844)

How strange, usually when PR is merged, it turns out to be merged. 🤔

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/c4144951370@github.com>

[Pierluigi Lenoci]

pierluigilenoci left a comment (vim/vim#19844)

However thank you 🚀

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19844/c4144953518@github.com>