[vim/vim] Modified syntax highlighting for scheme to include the named-lambda special form. (PR #19966)
plgfro
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19966
Commit Summary
- d800565 Signed-off-by: fro <fro_an...@proton.me>
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19966)Did you check with the maintainer of the file? ping @evanh
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
plgfro
plgfro left a comment (vim/vim#19966)No, I did not check with the maintainer of the file. I apologize.
@evhan, could you possibly take a look at this (issue regarding named-lambda special form not being syntax highlighted)? I apologize for opening a PR before contacting - I did not read the README thoroughly enough.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evan Hanson
evhan left a comment (vim/vim#19966)Hey @plgfro, no worries.
In general the highlighting is only meant to cover R7RS keywords, unless another dialect is enabled.
It looks like named-lambda is an MIT Scheme extension? I'd be fine with adding this, but I'd prefer to put it behind an is_mit_scheme variable similar to how we currently do with is_chicken (e.g. here). Otherwise, we'll be highlighting things that are not keywords in other versions of Scheme.
Is that OK with you?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
plgfro
plgfro left a comment (vim/vim#19966)Go for it! I simply made this PR under my accidentally conflating both MIT-Scheme and Scheme, so I could revise the PR to add the "is_mit_scheme" feature.
Do let me know if you wish for me to do this, or if you can handle it. (I currently do not have enough knowledge to do such, but I am certain that I can learn.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evan Hanson
evhan left a comment (vim/vim#19966)That's OK, it was easy enough for me to do it.
I've added named-lambda and a few other special forms that I found with a quick scan of the documentation to the upstream plugin here.
I'll make sure @chrisbra gets this next time the syntax files are updated. Thanks for the nudge, let me know if you'd like me to add your full name to the acknowledgements!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Fro
fro-andrometa left a comment (vim/vim#19966)Thank you!
Also, no need to include my name within the acknowledgments, as this was such a minor change. Thanks for the offer, though.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19966)thanks, closing then here. @evhan please create a PR with your changes whenever you are ready for this. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.