[vim/vim] /runtime/syntax/vim.vim # Enn w/o vim9CommentTitle (PR #19390)

Peter Kenny

unread,

Feb 12, 2026, 3:04:54 PM (2 days ago) Feb 12

to vim/vim, Subscribed

The vim.vim syntax file applies vim9CommentTitle highlight group to an "E", then 1-4 numbers, then colon comment when it is a standalone comment. That makes for odd highlighting in Vim9 script where the comment is about an error code. The following screenshots show current and after:

image.png (view on web)

image.png (view on web)

This change shouldn’t impact any other vim9CommentTitle patterns, though if there is a better way, all good.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19390

Commit Summary

8d017c2 C:/Program Files/Git/runtime/syntax/vim.vim # Enn w/o vim9CommentTitle

File Changes

(1 file)

M runtime/syntax/vim.vim (2)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Aliaksei Budavei

unread,

Feb 12, 2026, 3:45:26 PM (2 days ago) Feb 12

to vim/vim, Subscribed

zzzyxwvut left a comment (vim/vim#19390)

The routine for submitting changes to runtime/syntax/vim.vim
is somewhat roundabout on account of code generation:

cd runtime/syntax/generator

# MAKE MANUAL CHANGES TO THIS FILE.
vim vim.vim.base

make
git add ../vim.vim vim.vim.base
cd ..
make clean vim test

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Peter Kenny

unread,

Feb 12, 2026, 4:42:11 PM (2 days ago) Feb 12

to vim/vim, Subscribed

kennypete left a comment (vim/vim#19390)

The routine for submitting changes to runtime/syntax/vim.vim is somewhat roundabout on account of code generation:

Sorry, I didn't realise, though my mistake in not noticing the warning at the top of runtime/syntax/vim.vim.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Peter Kenny

unread,

Feb 12, 2026, 5:57:31 PM (2 days ago) Feb 12

to vim/vim, Push

@kennypete pushed 1 commit.

03acc8f C:/Program Files/Git/runtime/syntax/vim.vim # Enn w/o vim9CommentTitle

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Feb 13, 2026, 2:40:10 AM (yesterday) Feb 13

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19390)

thanks, can you add a syntax test for this please? I'd guess this needs to go to runtime/syntax/testdir/input/vim_comments.vim and then you'd need to re-generate the dump files:

cd runtime/syntax
make

The syntax test will then fail with your new changes. Please inspect the failed dump file (using the command mentioned in the output viewdumps.vim) make sure it fits your purpose and then just update the dump file please.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Peter Kenny

unread,

1:01 PM (5 hours ago) 1:01 PM

to vim/vim, Push

@kennypete pushed 1 commit.

f23df68 C:/Program Files/Git/runtime/syntax/vim.vim # Enn w/o vim9CommentTitle

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Peter Kenny

unread,

1:22 PM (5 hours ago) 1:22 PM

to vim/vim, Subscribed

kennypete left a comment (vim/vim#19390)

thanks, can you add a syntax test for this please? I'd guess this needs to go to runtime/syntax/testdir/input/vim_comments.vim and then you'd need to re-generate the dump files:
cd runtime/syntax
make
The syntax test will then fail with your new changes. Please inspect the failed dump file (using the command mentioned in the output viewdumps.vim) make sure it fits your purpose and then just update the dump file please.

There were two files needing the syntax test (vim9_comments.vim is the main one for any whole-line comments), though with Vim9 script scope in legacy Vim script :def functions, vim_comments.vim also needed the test. It all looks fine, I think, the dumps are updated, and 'pass' on re-make.

"Adjusting a syntax plugin test" in runtime/syntax/testdir/README.txt was helpful. Hopefully I haven't missed anything - it was slightly nerve-racking, though educational.