[vim/vim] Fix GTK quirks, mostly re: ancient GTK2 support (PR #18708)

[Drew Vogel]

This PR addresses a few quirks:

• Removes support for GTK2 <2.4. This code is almost surely never used by any platform compiling VIM today. This is because VIM requires Cairo for drawing and GTK switched to Cairo with GTK 2.8.
• Renames gui_gtk2_draw_string to gui_gtk_draw_string. The name was originally chosen to clearly separate it from the GTK1 support that was removed long ago. In reality this function has been used by GTK2 and GTK3 since GTK3 support was added nearly a decade ago.
• A compilation error due to comma placement when !FEAT_PROP_POPUP which is improbable but technically possible.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18708

Commit Summary

• c5b4dec Problem: GTK failed to compile with !FEAT_PROP_POPUP
• 2a14aca Problem: GTK naming reflected GTK1 support.
• f4064d6 Problem: Excessive GTK2 support.

File Changes

(7 files)

• M src/drawline.c (8)
• M src/evalfunc.c (2)
• M src/gui.c (4)
• M src/gui_gtk.c (83)
• M src/gui_gtk_x11.c (10)
• M src/proto/gui_gtk_x11.pro (4)
• M src/vim.h (6)

Patch Links:

• https://github.com/vim/vim/pull/18708.patch
• https://github.com/vim/vim/pull/18708.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18708@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18708)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18708/c3513671440@github.com>

[Christian Brabandt]

Closed #18708 via 1b92b27.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18708/issue_event/20845940887@github.com>