[vim/vim] Integer overflow with large 'sidescrolloff' (PR #20026)

4 views
Skip to first unread message

zeertzjq

unread,
Apr 20, 2026, 10:27:19 AM (yesterday) Apr 20
to vim/vim, Subscribed

Problem: Integer overflow with large 'sidescrolloff'.
Solution: Check for overflow.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20026

Commit Summary

  • 8d1a7da Integer overflow with large 'sidescrolloff'

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026@github.com>

zeertzjq

unread,
Apr 20, 2026, 10:30:02 AM (yesterday) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • a0eb565 Integer overflow with large 'sidescrolloff'


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/8d1a7daee96c852c2747893f57c5a8d596d1442f/after/a0eb5653976ce100a53db16c6cf4bbbeefd73492@github.com>

zeertzjq

unread,
Apr 20, 2026, 11:25:45 AM (yesterday) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • d6faa64 Integer overflow with "ze" and large 'sidescrolloff'

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/9b55a1fc61cf6c402dda8cb1a1a0d7e0c58554d3/after/d6faa64a356a1b11b9ed4b4cb41e5dcd628110aa@github.com>

zeertzjq

unread,
Apr 20, 2026, 11:29:21 AM (yesterday) Apr 20
to vim/vim, Subscribed

@zeertzjq commented on this pull request.


In src/move.c:

> @@ -1329,9 +1328,9 @@ curs_columns(
 		if (diff < p_ss)
 		    diff = p_ss;
 		if (off_left < 0)
-		    new_leftcol = curwin->w_leftcol - diff;
+		    new_leftcol = curwin->w_leftcol - (int)diff;

Only reaching here when diff < width1 / 2


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/review/4141304818@github.com>

zeertzjq

unread,
Apr 20, 2026, 6:43:33 PM (21 hours ago) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • e721a1f Integer overflow with "ze" and large 'sidescrolloff'

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/d6faa64a356a1b11b9ed4b4cb41e5dcd628110aa/after/e721a1f3a1675020cb8d9219b0dfc1da47e652f8@github.com>

zeertzjq

unread,
Apr 20, 2026, 7:05:20 PM (21 hours ago) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • 29f0dba Integer overflow with "ze" and large 'sidescrolloff'

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/e721a1f3a1675020cb8d9219b0dfc1da47e652f8/after/29f0dbab3d860caf5683e6e0a6ea77a005757b15@github.com>

zeertzjq

unread,
Apr 20, 2026, 7:12:24 PM (21 hours ago) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • 50a5abf Integer overflow with "ze" and large 'sidescrolloff'

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/29f0dbab3d860caf5683e6e0a6ea77a005757b15/after/50a5abf3344b41a44a5ad1368cad068d8de8f3c2@github.com>

zeertzjq

unread,
Apr 20, 2026, 8:26:00 PM (19 hours ago) Apr 20
to vim/vim, Push

@zeertzjq pushed 1 commit.

  • e9e619b Integer overflow with "ze" and large 'sidescrolloff'

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/before/50a5abf3344b41a44a5ad1368cad068d8de8f3c2/after/e9e619bae500982aa7665c0fe59a890318b9a0dd@github.com>

Christian Brabandt

unread,
3:41 PM (10 minutes ago) 3:41 PM
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#20026)

thanks


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/c4291299415@github.com>

Christian Brabandt

unread,
3:50 PM (1 minute ago) 3:50 PM
to vim/vim, Subscribed

Closed #20026 via 33f3965.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20026/issue_event/24731451883@github.com>

Reply all
Reply to author
Forward
0 new messages