Patch 8.2.4670

[Bram Moolenaar]

Patch 8.2.4670
Problem: Memory allocation failures for new tab page not tested.
Solution: Add tests with failing memory allocation. (Yegappan Lakshmanan,
closes #10067)
Files: src/alloc.h, src/blob.c, src/buffer.c, src/window.c,
src/testdir/test_blob.vim, src/testdir/test_buffer.vim,
src/testdir/test_tabpage.vim, src/testdir/test_window_cmd.vim


*** ../vim-8.2.4669/src/alloc.h 2022-04-02 21:46:14.989612828 +0100
--- src/alloc.h 2022-04-03 11:14:32.028202466 +0100
***************
*** 40,45 ****
aid_sign_getplaced_list,
aid_insert_sign,
aid_sign_getinfo,
! aid_buflistnew_bvars,
aid_last
} alloc_id_T;
--- 40,48 ----
aid_sign_getplaced_list,
aid_insert_sign,
aid_sign_getinfo,
! aid_newbuf_bvars,
! aid_newwin_wvars,
! aid_newtabpage_tvars,
! aid_blob_alloc,
aid_last
} alloc_id_T;
*** ../vim-8.2.4669/src/blob.c 2022-01-28 15:28:00.200927841 +0000
--- src/blob.c 2022-04-03 11:14:32.028202466 +0100
***************
*** 22,28 ****
blob_T *
blob_alloc(void)
{
! blob_T *blob = ALLOC_CLEAR_ONE(blob_T);

if (blob != NULL)
ga_init2(&blob->bv_ga, 1, 100);
--- 22,28 ----
blob_T *
blob_alloc(void)
{
! blob_T *blob = ALLOC_CLEAR_ONE_ID(blob_T, aid_blob_alloc);

if (blob != NULL)
ga_init2(&blob->bv_ga, 1, 100);
*** ../vim-8.2.4669/src/buffer.c 2022-04-02 21:46:14.989612828 +0100
--- src/buffer.c 2022-04-03 11:14:32.028202466 +0100
***************
*** 2093,2099 ****
}
#ifdef FEAT_EVAL
// init b: variables
! buf->b_vars = dict_alloc_id(aid_buflistnew_bvars);
if (buf->b_vars == NULL)
{
vim_free(ffname);
--- 2093,2099 ----
}
#ifdef FEAT_EVAL
// init b: variables
! buf->b_vars = dict_alloc_id(aid_newbuf_bvars);
if (buf->b_vars == NULL)
{
vim_free(ffname);
*** ../vim-8.2.4669/src/window.c 2022-04-02 21:46:14.989612828 +0100
--- src/window.c 2022-04-03 11:14:32.028202466 +0100
***************
*** 3801,3806 ****
--- 3801,3808 ----
win_alloc_firstwin(win_T *oldwin)
{
curwin = win_alloc(NULL, FALSE);
+ if (curwin == NULL)
+ return FAIL;
if (oldwin == NULL)
{
// Very first window, need to create an empty buffer for it and
***************
*** 3882,3888 ****

# ifdef FEAT_EVAL
// init t: variables
! tp->tp_vars = dict_alloc();
if (tp->tp_vars == NULL)
{
vim_free(tp);
--- 3884,3890 ----

# ifdef FEAT_EVAL
// init t: variables
! tp->tp_vars = dict_alloc_id(aid_newtabpage_tvars);
if (tp->tp_vars == NULL)
{
vim_free(tp);
***************
*** 5020,5026 ****

#ifdef FEAT_EVAL
// init w: variables
! new_wp->w_vars = dict_alloc();
if (new_wp->w_vars == NULL)
{
win_free_lsize(new_wp);
--- 5022,5028 ----

#ifdef FEAT_EVAL
// init w: variables
! new_wp->w_vars = dict_alloc_id(aid_newwin_wvars);
if (new_wp->w_vars == NULL)
{
win_free_lsize(new_wp);
*** ../vim-8.2.4669/src/testdir/test_blob.vim 2022-01-29 21:45:30.481921547 +0000
--- src/testdir/test_blob.vim 2022-04-03 11:14:32.028202466 +0100
***************
*** 702,705 ****
--- 702,744 ----
call assert_equal(v, string(b))
endfunc

+ " Test for blob allocation failure
+ func Test_blob_alloc_failure()
+ " blob variable
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let v = 0z10', 'E342:')
+
+ " blob slice
+ let v = 0z1020
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let x = v[0:0]', 'E342:')
+ call assert_equal(0z1020, x)
+
+ " blob remove()
+ let v = 0z10203040
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let x = remove(v, 1, 2)', 'E342:')
+ call assert_equal(0, x)
+
+ " list2blob()
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let a = list2blob([1, 2, 4])', 'E342:')
+ call assert_equal(0, a)
+
+ " mapnew()
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let x = mapnew(0z1234, {_, v -> 1})', 'E342:')
+ call assert_equal(0, x)
+
+ " copy()
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let x = copy(v)', 'E342:')
+ call assert_equal(0z, x)
+
+ " readblob()
+ call test_alloc_fail(GetAllocId('blob_alloc'), 0, 0)
+ call assert_fails('let x = readblob("test_blob.vim")', 'E342:')
+ call assert_equal(0, x)
+ endfunc
+
" vim: shiftwidth=2 sts=2 expandtab
*** ../vim-8.2.4669/src/testdir/test_buffer.vim 2022-04-02 21:46:14.989612828 +0100
--- src/testdir/test_buffer.vim 2022-04-03 11:14:32.028202466 +0100
***************
*** 430,479 ****
set maxmem& maxmemtot&
endfunc

! " Test for a allocation failure when adding a new buffer
func Test_buflist_alloc_failure()
%bw!

edit Xfile1
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('edit Xfile2', 'E342:')

" test for bufadd()
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('call bufadd("Xbuffer")', 'E342:')

" test for setting the arglist
edit Xfile2
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('next Xfile3', 'E342:')

" test for setting the alternate buffer name when writing a file
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('write Xother', 'E342:')
call delete('Xother')

" test for creating a buffer using bufnr()
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails("call bufnr('Xnewbuf', v:true)", 'E342:')

" test for renaming buffer using :file
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('file Xnewfile', 'E342:')

" test for creating a buffer for a popup window
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('call popup_create("mypop", {})', 'E342:')

if has('terminal')
" test for creating a buffer for a terminal window
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('call term_start(&shell)', 'E342:')
%bw!
endif

" test for loading a new buffer after wiping out all the buffers
edit Xfile4
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('%bw!', 'E342:')

" test for :checktime loading the buffer
--- 430,479 ----
set maxmem& maxmemtot&
endfunc

! " Test for buffer allocation failure
func Test_buflist_alloc_failure()
%bw!

edit Xfile1
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('edit Xfile2', 'E342:')

" test for bufadd()
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('call bufadd("Xbuffer")', 'E342:')

" test for setting the arglist
edit Xfile2
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('next Xfile3', 'E342:')

" test for setting the alternate buffer name when writing a file
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('write Xother', 'E342:')
call delete('Xother')

" test for creating a buffer using bufnr()
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails("call bufnr('Xnewbuf', v:true)", 'E342:')

" test for renaming buffer using :file
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('file Xnewfile', 'E342:')

" test for creating a buffer for a popup window
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('call popup_create("mypop", {})', 'E342:')

if has('terminal')
" test for creating a buffer for a terminal window
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('call term_start(&shell)', 'E342:')
%bw!
endif

" test for loading a new buffer after wiping out all the buffers
edit Xfile4
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('%bw!', 'E342:')

" test for :checktime loading the buffer
***************
*** 484,502 ****
sleep 200m
call writefile(['two'], 'Xfile5')
set autoread
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('checktime', 'E342:')
set autoread&
bw!
endif

" test for :vimgrep loading a dummy buffer
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('vimgrep two Xfile5', 'E342:')
call delete('Xfile5')

" test for quickfix command loading a buffer
! call test_alloc_fail(GetAllocId('buflistnew_bvars'), 0, 0)
call assert_fails('cexpr "Xfile6:10:Line10"', 'E342:')
endfunc

--- 484,502 ----
sleep 200m
call writefile(['two'], 'Xfile5')
set autoread
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('checktime', 'E342:')
set autoread&
bw!
endif

" test for :vimgrep loading a dummy buffer
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('vimgrep two Xfile5', 'E342:')
call delete('Xfile5')

" test for quickfix command loading a buffer
! call test_alloc_fail(GetAllocId('newbuf_bvars'), 0, 0)
call assert_fails('cexpr "Xfile6:10:Line10"', 'E342:')
endfunc

*** ../vim-8.2.4669/src/testdir/test_tabpage.vim 2021-01-26 21:42:17.694836803 +0000
--- src/testdir/test_tabpage.vim 2022-04-03 11:14:32.028202466 +0100
***************
*** 852,855 ****
--- 852,878 ----
tabonly!
endfunc

+ " Test for tabpage allocation failure
+ func Test_tabpage_alloc_failure()
+ call test_alloc_fail(GetAllocId('newtabpage_tvars'), 0, 0)
+ call assert_fails('tabnew', 'E342:')
+
+ call test_alloc_fail(GetAllocId('newtabpage_tvars'), 0, 0)
+ edit Xfile1
+ call assert_fails('tabedit Xfile2', 'E342:')
+ call assert_equal(1, winnr('$'))
+ call assert_equal(1, tabpagenr('$'))
+ call assert_equal('Xfile1', @%)
+
+ new
+ call test_alloc_fail(GetAllocId('newtabpage_tvars'), 0, 0)
+ call assert_fails('wincmd T', 'E342:')
+ bw!
+
+ call test_alloc_fail(GetAllocId('newtabpage_tvars'), 0, 0)
+ call assert_fails('tab split', 'E342:')
+ call assert_equal(2, winnr('$'))
+ call assert_equal(1, tabpagenr('$'))
+ endfunc
+
" vim: shiftwidth=2 sts=2 expandtab
*** ../vim-8.2.4669/src/testdir/test_window_cmd.vim 2022-01-29 10:59:48.505909435 +0000
--- src/testdir/test_window_cmd.vim 2022-04-03 11:14:32.028202466 +0100
***************
*** 1512,1516 ****
--- 1512,1560 ----
%bwipe!
endfunc

+ " Test for window allocation failure
+ func Test_window_alloc_failure()
+ %bw!
+
+ " test for creating a new window above current window
+ call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ call assert_fails('above new', 'E342:')
+ call assert_equal(1, winnr('$'))
+
+ " test for creating a new window below current window
+ call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ call assert_fails('below new', 'E342:')
+ call assert_equal(1, winnr('$'))
+
+ " test for popup window creation failure
+ call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ call assert_fails('call popup_create("Hello", {})', 'E342:')
+ call assert_equal([], popup_list())
+
+ call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ call assert_fails('split', 'E342:')
+ call assert_equal(1, winnr('$'))
+
+ edit Xfile1
+ edit Xfile2
+ call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ call assert_fails('sb Xfile1', 'E342:')
+ call assert_equal(1, winnr('$'))
+ call assert_equal('Xfile2', @%)
+ %bw!
+
+ " FIXME: The following test crashes Vim
+ " test for new tabpage creation failure
+ " call test_alloc_fail(GetAllocId('newwin_wvars'), 0, 0)
+ " call assert_fails('tabnew', 'E342:')
+ " call assert_equal(1, tabpagenr('$'))
+ " call assert_equal(1, winnr('$'))
+
+ " This test messes up the internal Vim window/frame information. So the
+ " Test_window_cmd_cmdwin_with_vsp() test fails after running this test.
+ " Open a new tab and close everything else to fix this issue.
+ tabnew
+ tabonly
+ endfunc

" vim: shiftwidth=2 sts=2 expandtab
*** ../vim-8.2.4669/src/version.c 2022-04-02 21:59:02.485697387 +0100
--- src/version.c 2022-04-03 11:17:39.852023001 +0100
***************
*** 752,753 ****
--- 752,755 ----
{ /* Add new patch number below this line */
+ /**/
+ 4670,
/**/

--
[Another hideous roar.]
BEDEVERE: That's it!
ARTHUR: What?
BEDEVERE: It's The Legendary Black Beast of Aaaaarrrrrrggghhh!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[John Marriott]

On 03-Apr-2022 20:23, Bram Moolenaar wrote:
> Patch 8.2.4670
> Problem: Memory allocation failures for new tab page not tested.
> Solution: Add tests with failing memory allocation. (Yegappan Lakshmanan,
> closes #10067)
> Files: src/alloc.h, src/blob.c, src/buffer.c, src/window.c,
> src/testdir/test_blob.vim, src/testdir/test_buffer.vim,
> src/testdir/test_tabpage.vim, src/testdir/test_window_cmd.vim
>
>

After applying patches 8.2.4670 to 8.2.4677, mingw64 (gcc 11.2.0) throws
this linker error:
<snip>
gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO
-pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return
-fpie -fPIE -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD -Wl,-nxcompat,-dynamicbase
-municode -s -mwindows -o gvim.exe gobjnative/alloc.o
gobjnative/arabic.o gobjnative/arglist.o gobjnative/autocmd.o
gobjnative/beval.o gobjnative/blob.o gobjnative/blowfish.o
gobjnative/buffer.o gobjnative/bufwrite.o gobjnative/change.o
gobjnative/charset.o gobjnative/cindent.o gobjnative/clientserver.o
gobjnative/clipboard.o gobjnative/cmdexpand.o gobjnative/cmdhist.o
gobjnative/crypt.o gobjnative/crypt_zip.o gobjnative/debugger.o
gobjnative/dict.o gobjnative/diff.o gobjnative/digraph.o
gobjnative/drawline.o gobjnative/drawscreen.o gobjnative/edit.o
gobjnative/eval.o gobjnative/evalbuffer.o gobjnative/evalfunc.o
gobjnative/evalvars.o gobjnative/evalwindow.o gobjnative/ex_cmds.o
gobjnative/ex_cmds2.o gobjnative/ex_docmd.o gobjnative/ex_eval.o
gobjnative/ex_getln.o gobjnative/fileio.o gobjnative/filepath.o
gobjnative/findfile.o gobjnative/float.o gobjnative/fold.o
gobjnative/getchar.o gobjnative/gui_xim.o gobjnative/hardcopy.o
gobjnative/hashtab.o gobjnative/help.o gobjnative/highlight.o
gobjnative/if_cscope.o gobjnative/indent.o gobjnative/insexpand.o
gobjnative/json.o gobjnative/list.o gobjnative/locale.o
gobjnative/main.o gobjnative/map.o gobjnative/mark.o gobjnative/match.o
gobjnative/memfile.o gobjnative/memline.o gobjnative/menu.o
gobjnative/message.o gobjnative/misc1.o gobjnative/misc2.o
gobjnative/mouse.o gobjnative/move.o gobjnative/mbyte.o
gobjnative/normal.o gobjnative/ops.o gobjnative/option.o
gobjnative/optionstr.o gobjnative/os_mswin.o gobjnative/os_win32.o
gobjnative/pathdef.o gobjnative/popupmenu.o gobjnative/popupwin.o
gobjnative/profiler.o gobjnative/quickfix.o gobjnative/regexp.o
gobjnative/register.o gobjnative/scriptfile.o gobjnative/screen.o
gobjnative/search.o gobjnative/session.o gobjnative/sha256.o
gobjnative/sign.o gobjnative/spell.o gobjnative/spellfile.o
gobjnative/spellsuggest.o gobjnative/strings.o gobjnative/syntax.o
gobjnative/tag.o gobjnative/term.o gobjnative/testing.o
gobjnative/textformat.o gobjnative/textobject.o gobjnative/textprop.o
gobjnative/time.o gobjnative/typval.o gobjnative/ui.o gobjnative/undo.o
gobjnative/usercmd.o gobjnative/userfunc.o gobjnative/version.o
gobjnative/vim9cmds.o gobjnative/vim9compile.o gobjnative/vim9execute.o
gobjnative/vim9expr.o gobjnative/vim9instr.o gobjnative/vim9script.o
gobjnative/vim9type.o gobjnative/viminfo.o gobjnative/winclip.o
gobjnative/window.o gobjnative/os_w32exe.o gobjnative/vimres.o
gobjnative/xdiffi.o gobjnative/xemit.o gobjnative/xprepare.o
gobjnative/xutils.o gobjnative/xhistogram.o gobjnative/xpatience.o
gobjnative/gui.o gobjnative/gui_w32.o gobjnative/gui_beval.o -lkernel32
-luser32 -lgdi32 -ladvapi32 -lcomdlg32 -lcomctl32 -lnetapi32 -lversion
-lole32 -luuid
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x11): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x54): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0xe1): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x4e7): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x70b): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0xa61): more undefined references to
`alloc_clear_id' follow
collect2.exe: error: ld returned 1 exit status
make: *** [Make_cyg_ming.mak:1107: gvim.exe] Error 2
</snip>

Sorry I don't have a patch.

Cheers
John

[John Marriott]

Hi All,

The attached patch seems to fix it.

Cheers
John

[Bram Moolenaar]

John Marriott wrote:

> > On 03-Apr-2022 20:23, Bram Moolenaar wrote:
> >> Patch 8.2.4670

> >> Problem:=C2=A0=C2=A0=C2=A0 Memory allocation failures for new tab page n=
> ot tested.
> >> Solution:=C2=A0=C2=A0 Add tests with failing memory allocation. (Yegappa=
> n=20
> >> Lakshmanan,
> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
> closes #10067)
> >> Files:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src/alloc.h, src/blob.c, src/buffer=
> .c, src/window.c,
> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
> src/testdir/test_blob.vim, src/testdir/test_buffer.vim,
> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
> src/testdir/test_tabpage.vim,=20
> >> src/testdir/test_window_cmd.vim
> >>
> >>
> > After applying patches 8.2.4670 to 8.2.4677, mingw64 (gcc 11.2.0)=20

> > throws this linker error:
> > <snip>
> > gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603

[...]

> > -lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lole32 -luuid
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0x11): undefined reference to
> > `alloc_clear_id'
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0x54): undefined reference to
> > `alloc_clear_id'
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0xe1): undefined reference to
> > `alloc_clear_id'
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0x4e7): undefined reference to
> > `alloc_clear_id'
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0x70b): undefined reference to
> > `alloc_clear_id'
> > d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-> mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> > gobjnative/blob.o:blob.c:(.text+0xa61): more undefined references to
> > `alloc_clear_id' follow
> > collect2.exe: error: ld returned 1 exit status
> > make: *** [Make_cyg_ming.mak:1107: gvim.exe] Error 2
> > </snip>

Apparently this combination of features is not covered by CI.

> > Sorry I don't have a patch.

Terrible! :-)

> The attached patch seems to fix it.

Ah, there it is. Thanks.

--
BEDEVERE: How do you know so much about swallows?
ARTHUR: Well you have to know these things when you're a king, you know.