[vim/vim] patch 8.2.4754: add openscad filetype and syntax (PR #10199)

8 views
Skip to first unread message

niklas adam

unread,
Apr 15, 2022, 4:26:20 PM4/15/22
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/10199

Commit Summary

  • b287857 patch 8.2.4754: add openscad filetype and syntax

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199@github.com>

Bram Moolenaar

unread,
Apr 16, 2022, 4:30:17 PM4/16/22
to vim/vim, Subscribed

I'll make a patch for the filetype detection. The syntax file will be in the next runtime files update.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199/c1100750089@github.com>

Bram Moolenaar

unread,
Apr 16, 2022, 4:34:37 PM4/16/22
to vim/vim, Subscribed

Closed #10199 via c360b25.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199/issue_event/6443801815@github.com>

Bram Moolenaar

unread,
Apr 16, 2022, 4:37:31 PM4/16/22
to vim/vim, Subscribed

I notice the syntax file is setting 'iskeyword'. If that is really what you want, this belongs in a filetype plugin.
If this was intended to be used for the syntax file, the ":syn iskeyword" should be used.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199/c1100751433@github.com>

niklas adam

unread,
Apr 16, 2022, 5:37:07 PM4/16/22
to vim/vim, Subscribed

I notice the syntax file is setting 'iskeyword'. If that is really what you want, this belongs in a filetype plugin. If this was intended to be used for the syntax file, the ":syn iskeyword" should be used.

Ah true! Thanks. Should I create a new PR for the syntax or just force push again here, nevertheless that its closed?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199/c1100758448@github.com>

Bram Moolenaar

unread,
Apr 17, 2022, 7:58:34 AM4/17/22
to vim/vim, Subscribed

Please create a new PR. I had already included the file.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/10199/c1100861467@github.com>

Reply all
Reply to author
Forward
0 new messages