Commit: patch 9.2.0173: tests: Test_balloon_eval_term_visual is flaky

0 views
Skip to first unread message

Christian Brabandt

unread,
Mar 15, 2026, 12:02:01 PM (8 days ago) Mar 15
to vim...@googlegroups.com
patch 9.2.0173: tests: Test_balloon_eval_term_visual is flaky

Commit: https://github.com/vim/vim/commit/e21c4a649a830716599eadebad04ddf2393230bc
Author: Christian Brabandt <c...@256bit.org>
Date: Sun Mar 15 15:42:34 2026 +0000

patch 9.2.0173: tests: Test_balloon_eval_term_visual is flaky

Problem: tests: Test_balloon_eval_term_visual is flaky
Solution: Use redraw and WaitForAssert() to make it more reliable

Previously, it failed about 1 out of 4 runs for me, now I got it down to
1 out of 10. It's not perfect, but better than before.

closes: #19692

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_balloon.vim b/src/testdir/test_balloon.vim
index 1fe0ae890..8ff2f263a 100644
--- a/src/testdir/test_balloon.vim
+++ b/src/testdir/test_balloon.vim
@@ -53,12 +53,15 @@ func Test_balloon_eval_term_visual()
" the balloon.
call writefile(s:common_script + [
\ 'call test_setmouse(3, 6)',
- \ 'call feedkeys("3Gevfr\<MouseMove>\<Ignore>", "xt")',
+ \ 'call feedkeys("3Gevfr", "xt")',
+ \ 'redraw!',
+ \ 'call feedkeys("\<MouseMove>\<Ignore>", "xt")',
\ ], 'XTest_beval_visual', 'D')

" Check that the balloon shows up after a mouse move
let buf = RunVimInTerminal('-S XTest_beval_visual', {'rows': 10, 'cols': 50})
call TermWait(buf, 50)
+ call WaitForAssert({-> assert_match('-- VISUAL --', term_getline(buf, 10))})
call VerifyScreenDump(buf, 'Test_balloon_eval_term_02', {})

" clean up
diff --git a/src/version.c b/src/version.c
index bac40781c..50f92520a 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 173,
/**/
172,
/**/
Reply all
Reply to author
Forward
0 new messages