Test Failure

[Ernie Rael]

It's been weeks since I've built vim, and considering the impending
release I built and ran tests this morning.

-ernie

On linux, gtk3, 8.2.5141


Executed:  5206 Tests
 Skipped:    62 Tests
  FAILED:     1 Tests


Failures:
    From test_startup.vim:
    Found errors in Test_geometry():
    command line..script
/ref/vim/src/testdir/runtest.vim[464]..function
RunTheTest[44]..Test_geometry line 30: Expected '43' but got '130'
    command line..script
/ref/vim/src/testdir/runtest.vim[464]..function
RunTheTest[44]..Test_geometry line 31: Expected '[41, 43]' but got '[41,
130]'

[Bram Moolenaar]

I have not seen this failure, not on CI and not on my own system. I'm
just running all tests under valgrind (which takes a long time) and it
also doesn't fail then.

It might depend on your window manager perhaps.

--
ALL: A witch! A witch!
WITCH: It's a fair cop.
ALL: Burn her! Burn her! Let's make her into a ladder.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Ernie Rael]

On 6/20/22 10:45 AM, Bram Moolenaar wrote:
> Ernie Rael wrote:
>
>> It's been weeks since I've built vim, and considering the impending
>> release I built and ran tests this morning.
>>
>> -ernie
>>
>> On linux, gtk3, 8.2.5141
>>
>>
>> Executed:  5206 Tests
>>  Skipped:    62 Tests
>>   FAILED:     1 Tests
>>
>>
>> Failures:
>>     From test_startup.vim:
>>     Found errors in Test_geometry():
>>     command line..script
>> /ref/vim/src/testdir/runtest.vim[464]..function
>> RunTheTest[44]..Test_geometry line 30: Expected '43' but got '130'
>>     command line..script
>> /ref/vim/src/testdir/runtest.vim[464]..function
>> RunTheTest[44]..Test_geometry line 31: Expected '[41, 43]' but got '[41,
>> 130]'
> I have not seen this failure, not on CI and not on my own system. I'm
> just running all tests under valgrind (which takes a long time) and it
> also doesn't fail then.
>
> It might depend on your window manager perhaps.

I was unfamiliar with the -geometry option, there's a status bar across
the top of the laptop. Guess the bar must be 130 pixels in height.

-ernie

>

[Bram Moolenaar]

Possibly. Still, the window manager should compensate for that.

You could try changing "43" in Test_geometry() to 150.
Does that work, or does it then fail in another way?

--
Never under any circumstances take a sleeping pill
and a laxative on the same night.

[Ernie Rael]

Yes, it works fine with 150.

I asked for it to position at 43, it couldn't and it put it at 130.
Isn't that compensation? (Not that I'm trying to defend the window manager)

-ernie

[Bram Moolenaar]

Ernie Rael wrote:

> >>>> It's been weeks since I've built vim, and considering the impending
> >>>> release I built and ran tests this morning.
> >>>>
> >>>> -ernie
> >>>>
> >>>> On linux, gtk3, 8.2.5141
> >>>>
> >>>>

> >>>> Executed:=C2=A0 5206 Tests
> >>>> =C2=A0Skipped:=C2=A0=C2=A0=C2=A0 62 Tests
> >>>> =C2=A0 FAILED:=C2=A0=C2=A0=C2=A0=C2=A0 1 Tests
> >>>>
> >>>>
> >>>> Failures:
> >>>> =C2=A0=C2=A0 =C2=A0From test_startup.vim:
> >>>> =C2=A0=C2=A0 =C2=A0Found errors in Test_geometry():
> >>>> =C2=A0=C2=A0 =C2=A0command line..script

> >>>> /ref/vim/src/testdir/runtest.vim[464]..function
> >>>> RunTheTest[44]..Test_geometry line 30: Expected '43' but got '130'

> >>>> =C2=A0=C2=A0 =C2=A0command line..script
> >>>> /ref/vim/src/testdir/runtest.vim[464]..function
> >>>> RunTheTest[44]..Test_geometry line 31: Expected '[41, 43]' but got '[4=

> 1,
> >>>> 130]'
> >>> I have not seen this failure, not on CI and not on my own system. I'm
> >>> just running all tests under valgrind (which takes a long time) and it
> >>> also doesn't fail then.
> >>>
> >>> It might depend on your window manager perhaps.
> >> I was unfamiliar with the -geometry option, there's a status bar across
> >> the top of the laptop. Guess the bar must be 130 pixels in height.
> > Possibly. Still, the window manager should compensate for that.
> >
> > You could try changing "43" in Test_geometry() to 150.
> > Does that work, or does it then fail in another way?
> >
> Yes, it works fine with 150.
>

> I asked for it to position at 43, it couldn't and it put it at 130.=20

> Isn't that compensation? (Not that I'm trying to defend the window manager)

OK, so the window manager uses an absolute position, but then pushes the
window down to avoid overlapping the status bar. We can use 150 to
avoid that problem.

--
If you had to identify, in one word, the reason why the
human race has not achieved, and never will achieve, its
full potential, that word would be "meetings."