Patch 7.2.368

Bram Moolenaar

unread,

Feb 18, 2010, 9:53:41 AM2/18/10

to vim...@vim.org

Patch 7.2.368 (after 7.2.361)
Problem: Ruby interface: Appending line doesn't work. (Michael Henry)
Solution: Reverse check for NULL line. (James Vega)
Files: src/if_ruby.c

*** ../vim-7.2.367/src/if_ruby.c 2010-02-17 16:23:03.000000000 +0100
--- src/if_ruby.c 2010-02-18 15:47:42.000000000 +0100
***************
*** 869,875 ****
long n = NUM2LONG(num);
aco_save_T aco;

! if (line != NULL) {
rb_raise(rb_eIndexError, "NULL line");
}
else if (n >= 0 && n <= buf->b_ml.ml_line_count)
--- 869,875 ----
long n = NUM2LONG(num);
aco_save_T aco;

! if (line == NULL) {
rb_raise(rb_eIndexError, "NULL line");
}
else if (n >= 0 && n <= buf->b_ml.ml_line_count)
*** ../vim-7.2.367/src/version.c 2010-02-17 18:28:06.000000000 +0100
--- src/version.c 2010-02-18 15:48:09.000000000 +0100
***************
*** 683,684 ****
--- 683,686 ----
{ /* Add new patch number below this line */
+ /**/
+ 368,
/**/

--
hundred-and-one symptoms of being an internet addict:
251. You've never seen your closest friends who usually live WAY too far away.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Steve Hall

unread,

Feb 18, 2010, 11:19:42 AM2/18/10

to vim...@googlegroups.com, vim...@vim.org

From: Bram Moolenaar, Thu, February 18, 2010 9:53 am

>
> Patch 7.2.368 (after 7.2.361)
> Problem: Ruby interface: Appending line doesn't work. (Michael Henry)
> Solution: Reverse check for NULL line. (James Vega)
> Files: src/if_ruby.c

Build fails for me on WinXP-32 via Cygwin:

Warning: .drectve `-defaultlib:MSVCRT ' unrecognized
Warning: .drectve `-defaultlib:OLDNAMES ' unrecognized
gobj/if_ruby.o:if_ruby.c:(.text+0x9b5): undefined reference to
`_rb_string_value_ptr'
gobj/if_ruby.o:if_ruby.c:(.text+0xae3): undefined reference to
`_rb_string_value_ptr'
gobj/if_ruby.o:if_ruby.c:(.text+0xb0d): undefined reference to
`_rb_string_value_ptr'
gobj/if_ruby.o:if_ruby.c:(.text+0xb33): undefined reference to
`_rb_string_value_ptr'
gobj/if_ruby.o:if_ruby.c:(.text+0xe30): undefined reference to
`_rb_string_value_ptr'
gobj/if_ruby.o:if_ruby.c:(.text+0x104f): more undefined references to
`_rb_string_value_ptr' follow
collect2: ld returned 1 exit status
make: *** [gvim.exe] Error 1

--
Steve Hall [ digitect dancingpaper com ]

Bram Moolenaar

unread,

Feb 18, 2010, 2:22:32 PM2/18/10

to Steve Hall, vim...@vim.org

Steve Hall wrote:

Strange, patches 7.2.361 and 7.2.368 don't include "string_value".

This did get added:

+ #ifndef StringValuePtr
+ # define StringValuePtr(s) STR2CSTR(s)
+ #endif

Does that give a hint?

--
Emacs is a nice OS - but it lacks a good text editor.
That's why I am using Vim. --Anonymous

Cesar

unread,

Feb 18, 2010, 6:59:52 PM2/18/10

to vim_dev

I had vim 7.2.360 installed on Win XP via mingw, and by updating to
the last
patch I get the same error, even deleting those three lines.

Many thanks in advance,
Cesar

Cesar

unread,

Feb 22, 2010, 2:53:07 PM2/22/10

to vim_dev

If I set DYNAMIC_RUBY=no, it gets compiled with ruby 1.8
But with ruby 1.9 it doesn't get compiled whatever the value of
DYNAMIC_RUBY
is.

---
Cesar

Yongwei Wu

unread,

Feb 25, 2010, 3:59:51 AM2/25/10

to vim_dev

Any updates on this one? Ruby support failed for me too (MSVC on
Windows). I tried upgrading to Ruby 1.9.1, but it seems it does not
support MSVC yet. Currently I could only build a version without Ruby
support on Windows.

(I don't personally use Ruby, but I would like to provide a full-
featured Vim binary for distribution.)