[vim/vim] Added syntax for the structurizr DSL (#8764)

249 views
Skip to first unread message

Bastian Venthur

unread,
Aug 16, 2021, 6:23:53 AM8/16/21
to vim/vim, Subscribed

structurizr DSL is used in structurizr, which is a tool that allows to
model your software architecture according to the c4 model
(https://c4model.com/)

The default file extension is .dsl but it clashes with an existing (but
non-compatible) filetype. I have no idea to detect the appropriate
filetype based on a file, so for now you have to use set filetype
appropriately.

The language reference can be found here:
https://github.com/structurizr/dsl

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8764

Commit Summary

  • Added syntax for the structurizr DSL

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Bastian Venthur

unread,
Aug 16, 2021, 7:05:46 AM8/16/21
to vim/vim, Push

@venthur pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Bastian Venthur

unread,
Aug 16, 2021, 7:48:06 AM8/16/21
to vim/vim, Push

@venthur pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Bastian Venthur

unread,
Aug 16, 2021, 7:57:16 AM8/16/21
to vim/vim, Push

@venthur pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Doug Kearns

unread,
Aug 16, 2021, 8:16:31 AM8/16/21
to vim/vim, Subscribed

@dkearns commented on this pull request.

In runtime/filetype.vim:

> @@ -538,7 +538,12 @@ au BufNewFile,BufRead *.drac,*.drc,*lvs,*lpe	setf dracula
 au BufNewFile,BufRead *.ds			setf datascript
 
 " dsl
-au BufNewFile,BufRead *.dsl			setf dsl
+au BufNewFile,BufRead *.dsl
+	\ if getline(1) =~ '^<\!' |

You might want to use getline(nextnonblank(1)) here.

codecov[bot]

unread,
Aug 16, 2021, 8:18:35 AM8/16/21
to vim/vim, Subscribed

Codecov Report

Merging #8764 (fc4bfc5) into master (92755bb) will decrease coverage by 87.68%.
The diff coverage is n/a.

❗ Current head fc4bfc5 differs from pull request most recent head fca5bad. Consider uploading reports for the commit fca5bad to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@

##           master    #8764       +/-   ##

===========================================

- Coverage   90.14%    2.46%   -87.69%     

===========================================

  Files         151      149        -2     

  Lines      170644   165390     -5254     

===========================================

- Hits       153833     4072   -149761     

- Misses      16811   161318   +144507
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/float.c 0.00% <0.00%> (-99.22%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.54%) ⬇️
src/sound.c 0.00% <0.00%> (-97.12%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/match.c 0.00% <0.00%> (-96.98%) ⬇️
src/sha256.c 0.00% <0.00%> (-96.94%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.92%) ⬇️
src/textprop.c 0.00% <0.00%> (-96.82%) ⬇️
src/cmdhist.c 0.00% <0.00%> (-96.76%) ⬇️
src/debugger.c 0.00% <0.00%> (-96.62%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92755bb...fca5bad. Read the comment docs.

Bastian Venthur

unread,
Aug 16, 2021, 8:24:19 AM8/16/21
to vim/vim, Push

@venthur pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Doug Kearns

unread,
Aug 16, 2021, 8:31:42 AM8/16/21
to vim/vim, Subscribed

Shouldn't the dsl filetype really be dsssl? Is it worth changing at the same time?

Bastian Venthur

unread,
Aug 16, 2021, 8:57:11 AM8/16/21
to vim/vim, Subscribed

Shouldn't the dsl filetype really be dsssl? Is it worth changing at the same time?

I think yes, but I'm no expert on that matter. In any case, I guess that should go into a separate PR then.

Bram Moolenaar

unread,
Aug 17, 2021, 5:45:31 PM8/17/21
to vim/vim, Subscribed

Closed #8764 via dea5611.

Bastian Venthur

unread,
Aug 18, 2021, 2:11:15 AM8/18/21
to vim/vim, Subscribed

Hi @brammool is there anything left for me to do in order to get the missing syntax file merged?

Cheers!

Bram Moolenaar

unread,
Aug 18, 2021, 4:55:25 AM8/18/21
to vim/vim, Subscribed


> Hi @brammool is there anything left for me to do in order to get the
> missing syntax file merged?

It will be included in the next runtime files update.

--
Sometimes I think the surest sign that intelligent life exists elsewhere
in the universe is that none of it has tried to contact us. (Calvin)

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Gildas Quéméner

unread,
Sep 1, 2021, 8:53:21 AM9/1/21
to vim/vim, Subscribed

It seems that the patch that have been applied on master does not include the syntax file @brammool .

Doug Kearns

unread,
Sep 1, 2021, 9:20:05 AM9/1/21
to vim/vim, Subscribed

It was included with 89a9c15

Runtime files get updated periodically in batches.

Gildas Quéméner

unread,
Sep 1, 2021, 10:21:27 AM9/1/21
to vim/vim, Subscribed

My bad, I haven't found it first time I searched for it. Thanks!

Reply all
Reply to author
Forward
0 new messages