[vim/vim] runtime(zip): use system() instead of :! (PR #19370)
Mao-Yining
- ':!' is not stable, so use system() to get more consistent behaviour.
- Only warns when using 'pwsh'.
- Remove trailing spaces.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19370
Commit Summary
- 397d1a8 runtime(zip): use system() instead of :!
File Changes
(1 file)
- M runtime/autoload/zip.vim (11)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mao-Yining
mao-yining left a comment (vim/vim#19370)Hmm. I don't have linux. Could anybody help?
The purpose of this pr is to fix it working on GUI MS-Windows.
It was failed to open files
:!unzip -p -- "C:/abc.zip" > "C:\a.temp"
caution: filename not matched: >
caution: filename not matched: C:/a.temp
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19370)unzip has pretty nasty command line parsing rules. It seems to see the > as part a file name.
Perhaps this works:
:!cmd /c "unzip -p -- "C:\abc.zip" > "C:/a.temp""
Oh wrong, I think I misunderstood. What issue are you facing on Linux?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mao-Yining
mao-yining left a comment (vim/vim#19370)Oh wrong, I think I misunderstood. What issue are you facing on Linux?
After using system(), the linux test was failed.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
lxhillwind
lxhillwind left a comment (vim/vim#19370)When replacing :! with system(), s:Escape()'s second argument should also be altered with 0, since this argument is passed to shellescape() actually.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mao-Yining
@mao-yining pushed 1 commit.
- 23e892f runtime(zip): use system() instead of :!
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Mao-Yining
@mao-yining pushed 1 commit.
- 7d7f99b runtime(zip): use system() instead of :!
You are receiving this because you are subscribed to this thread.