[vim/vim] runtime(help): make help omnifunc global (PR #20024)
Peter Cardenas
Problem:
- The omnifunc for help tags completion is script local making it hard to use by plugins.
Solution:
- Make the function referenced by the omnifunc global.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20024
Commit Summary
- e6d5151 runtime(help): make help omnifunc global
File Changes
(1 file)
- M runtime/ftplugin/help.vim (40)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20024)Thanks, but why did you move the settings from lines 20-24 to 38-41? And why did you drop the if exists() condition?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Peter Cardenas
PeterCardenas left a comment (vim/vim#20024)why did you move the settings from lines 20-24 to 38-41
just a style preference to put function definitions before their references, can move back if we want to minimize diff
why did you drop the if exists() condition
saw in other files we didn't do it and saw we already had the early return at the top of the file so didn't seem necessary, can also add this back if we want to minimize diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.