[vim/vim] tests: terminal tests are flaky (PR #21039)

1 view

Skip to first unread message

h_east

unread,

9:13 AM (5 hours ago) 9:13 AM

to vim/vim, Subscribed

Problem:  Test_terminal_aucmd_on_close() is flaky on MS-Windows: the
          tests that wait for a terminal window to close use a timeout
          shorter than the default, which is not enough when starting a
          process is slow.  When the wait fails the test aborts with
          E121 and leaves an autocommand behind for the following tests.
          Test_terminal_unwraps() checks the buffer contents without
          waiting for the job to finish.
Solution: Use the default timeout of WaitForAssert(), initialize the
          variable checked after the wait, and wait for the buffer to
          hold the unwrapped line.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/21039

Commit Summary

cb0272a tests: terminal tests are flaky

File Changes

(1 file)

M src/testdir/test_terminal.vim (35)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

1:47 PM (1 hour ago) 1:47 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#21039)

thanks

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward

0 new messages