[vim/vim] runtime(compiler): fix space escape in pyright (PR #19354)
Mao-Yining
- escape the space
- remove trailing space
@Konfekt are you intentionally keep these commented lines?
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19354
Commit Summary
- 76d4427 runtime(compiler): fix space escape in pyright
File Changes
(2 files)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
In runtime/compiler/pyright.vim:
> exe 'CompilerSet makeprg=' .. escape(
\ get(b:, 'pyright_makeprg', get(g:, 'pyright_makeprg', 'pyright')),
\ ' \|"')
CompilerSet errorformat=
\%E%f:%l:%c\ -\ error:\ %m,
\%W%f:%l:%c\ -\ warning:\ %m,
\%N%f:%l:%c\ -\ note:\ %m,
- \%C[ \t]\ %.%#,
+ \%C[\ \t]\ %.%#,
did you intentionally include a backslash in the collection?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Mao-Yining
@mao-yining commented on this pull request.
In runtime/compiler/pyright.vim:
> exe 'CompilerSet makeprg=' .. escape(
\ get(b:, 'pyright_makeprg', get(g:, 'pyright_makeprg', 'pyright')),
\ ' \|"')
CompilerSet errorformat=
\%E%f:%l:%c\ -\ error:\ %m,
\%W%f:%l:%c\ -\ warning:\ %m,
\%N%f:%l:%c\ -\ note:\ %m,
- \%C[ \t]\ %.%#,
+ \%C[\ \t]\ %.%#,
Yes that is the main purpose of this pr.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Enno
@Konfekt commented on this pull request.
In runtime/compiler/pyright.vim:
>
if exists("current_compiler") | finish | endif
let current_compiler = "pyright"
let s:cpo_save = &cpo
set cpo&vim
-" CompilerSet makeprg=pyright
Yes, these are intentional for easier recognition of makeprg, say, by vim-dispatch
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Mao-Yining
@mao-yining pushed 1 commit.
- ed18851 runtime(compiler): fix space escape in pyright
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Mao-Yining
mao-yining left a comment (vim/vim#19354)@Konfekt Before this PR, don't you affect by that space without slash?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
Konfekt left a comment (vim/vim#19354)@mao-yining Thank you for the fix. I wonder myself how escaping got lost
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19354)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.