failure of LSP Test on vim-win32-installer

[Christian Brabandt]

Hi,
since the recent addition of the new lsp feature into vim, the test
Test_channel_lsp_mode() keeps on failing. See a log e.g. here:
https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/43077142/job/a5x2ss0xx1e1un4t

@Yegappan, do you know what is going wrong there?

It would be great to have this fixed, so that we can continue building
and providing Windows binaries.


Thanks,
Chris
--
Wer langsam denkt, braucht nicht zweimal zu denken!

[Yegappan Lakshmanan]

Hi Chris,

On Tue, Apr 5, 2022 at 2:45 AM Christian Brabandt <cbl...@256bit.org> wrote:
>
> Hi,
> since the recent addition of the new lsp feature into vim, the test
> Test_channel_lsp_mode() keeps on failing. See a log e.g. here:
> https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/43077142/job/a5x2ss0xx1e1un4t
>
> @Yegappan, do you know what is going wrong there?
>
> It would be great to have this fixed, so that we can continue building
> and providing Windows binaries.
>

I went through the logs and couldn't figure out why the LSP test is failing.
The same test passes in the Vim appveyor build
(https://ci.appveyor.com/project/chrisbra/vim/history) and on my local windows
system. Is there a python version difference between the Vim appveyor build
and this build?

Regards,
Yegappan

[Christian Brabandt]

It should be using python 3.10, that is downloaded separately and it is
using MVC to build.

Here are the version information:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 4 2022 22:02:29)
MS-Windows 64-bit GUI version with OLE support
Included patches: 1-4691
Compiled by appveyor@APPVYR-WIN
Huge version with GUI. Features included (+) or not (-):
+acl +ex_extra +mzscheme/dyn -tcl
+arabic +extra_search +netbeans_intg -termguicolors
+autocmd -farsi +num64 +terminal
+autochdir +file_in_path +ole -termresponse
+autoservername +find_in_path +packages +textobjects
+balloon_eval +float +path_extra +textprop
-balloon_eval_term +folding +perl/dyn -tgetent
+browse -footer +persistent_undo +timers
++builtin_terms +gettext/dyn +popupwin +title
+byte_offset -hangul_input -postscript +toolbar
+channel +iconv/dyn +printer +user_commands
+cindent +insert_expand +profile +vartabs
+clientserver +ipv6 +python/dyn +vertsplit
+clipboard +job +python3/dyn +vim9script
+cmdline_compl +jumplist +quickfix +viminfo
+cmdline_hist +keymap +reltime +virtualedit
+cmdline_info +lambda +rightleft +visual
+comments +langmap +ruby/dyn +visualextra
+conceal +libcall +scrollbind +vreplace
+cryptv +linebreak +signs -vtp
+cscope +lispindent +smartindent +wildignore
+cursorbind +listcmds +sodium/dyn +wildmenu
+cursorshape +localmap +sound +windows
+dialog_con_gui +lua/dyn +spell +writebackup
+diff +menu +startuptime -xfontset
+digraphs +mksession +statusline -xim
+directx +modify_fname -sun_workshop +xpm_w32
-dnd +mouse +syntax -xterm_save
-ebcdic +mouseshape +tag_binary
+emacs_tags +multi_byte_ime/dyn -tag_old_static
+eval +multi_lang -tag_any_white
system vimrc file: "$VIM\vimrc"
user vimrc file: "$HOME\_vimrc"
2nd user vimrc file: "$HOME\vimfiles\vimrc"
3rd user vimrc file: "$VIM\_vimrc"
user exrc file: "$HOME\_exrc"
2nd user exrc file: "$VIM\_exrc"
system gvimrc file: "$VIM\gvimrc"
user gvimrc file: "$HOME\_gvimrc"
2nd user gvimrc file: "$HOME\vimfiles\gvimrc"
3rd user gvimrc file: "$VIM\_gvimrc"
defaults file: "$VIMRUNTIME\defaults.vim"
system menu file: "$VIMRUNTIME\menu.vim"
Compilation: cl -c /W3 /GF /nologo -I. -Iproto -DHAVE_PATHDEF -DWIN32 -DFEAT_CSCOPE -DFEAT_TERMINAL -DFEAT_SOUND -DFEAT_NETBEANS_INTG -DFEAT_JOB_CHANNEL -DFEAT_IPV6 -DFEAT_XPM_W32 -DHAVE_SODIUM -DDYNAMIC_SODIUM -DDYNAMIC_SODIUM_DLL=\"libsodium.dll\" /I "C:\libsodium\include" -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 /source-charset:utf-8 /MP -DHAVE_STDINT_H /Ox /GL -DNDEBUG /Zl /MT /D_CRT_SECURE_NO_DEPRECATE /D_CRT_NONSTDC_NO_DEPRECATE -DFEAT_OLE -DFEAT_MBYTE_IME -DDYNAMIC_IME -DFEAT_GUI_MSWIN -DFEAT_DIRECTX -DDYNAMIC_DIRECTX -DFEAT_DIRECTX_COLOR_EMOJI -DDYNAMIC_ICONV -DDYNAMIC_GETTEXT -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL=\"lua54.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL=\"python310.dll\" -DFEAT_MZSCHEME -I "C:\racket\include" -DMZ_PRECISE_GC -DDYNAMIC_MZSCHEME -DDYNAMIC_MZSCH_DLL=\"libracket3m_da32rk.dll\" -DDYNAMIC_MZGC_DLL=\"libracket3m_da32rk.dll\" -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl532.dll\" -DFEAT_RUBY -DDYNAMIC_RUBY -DDYNAMIC_RUBY_DLL=\"x64-msvcrt-ruby300.dll\" -DRUBY_VERSION=30 -DFEAT_HUGE /Fd.\ObjGXOULYHRZAMD64/ /Zi
Linking: link /nologo /opt:ref /LTCG /HIGHENTROPYVA:NO oldnames.lib kernel32.lib advapi32.lib shell32.lib gdi32.lib comdlg32.lib ole32.lib netapi32.lib uuid.lib user32.lib /machine:AMD64 version.lib winspool.lib comctl32.lib libcmt.lib oleaut32.lib /nodefaultlib:lua54.lib /STACK:8388608 /nodefaultlib:python27.lib /nodefaultlib:python310.lib winmm.lib WSock32.lib Ws2_32.lib xpm\x64\lib-vc14\libXpm.lib /PDB:gvim.pdb -debug

C:\projects\vim-win32-installer\vim\src>.\vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 4 2022 22:03:28)
MS-Windows 64-bit console version
Included patches: 1-4691
Compiled by appveyor@APPVYR-WIN
Huge version without GUI. Features included (+) or not (-):
+acl +ex_extra +multi_lang -tag_any_white
+arabic +extra_search +mzscheme/dyn -tcl
+autocmd -farsi -netbeans_intg +termguicolors
+autochdir +file_in_path +num64 +terminal
+autoservername +find_in_path +packages -termresponse
-balloon_eval +float +path_extra +textobjects
+balloon_eval_term +folding +perl/dyn +textprop
-browse -footer +persistent_undo -tgetent
++builtin_terms +gettext/dyn +popupwin +timers
+byte_offset -hangul_input -postscript +title
+channel +iconv/dyn +printer -toolbar
+cindent +insert_expand +profile +user_commands
+clientserver +ipv6 +python/dyn +vartabs
+clipboard +job +python3/dyn +vertsplit
+cmdline_compl +jumplist +quickfix +vim9script
+cmdline_hist +keymap +reltime +viminfo
+cmdline_info +lambda +rightleft +virtualedit
+comments +langmap +ruby/dyn +visual
+conceal +libcall +scrollbind +visualextra
+cryptv +linebreak +signs +vreplace
+cscope +lispindent +smartindent +vtp
+cursorbind +listcmds +sodium/dyn +wildignore
+cursorshape +localmap +sound +wildmenu
+dialog_con +lua/dyn +spell +windows
+diff +menu +startuptime +writebackup
+digraphs +mksession +statusline -xfontset
-dnd +modify_fname -sun_workshop -xim
-ebcdic +mouse +syntax -xpm_w32
+emacs_tags -mouseshape +tag_binary -xterm_save
+eval +multi_byte_ime/dyn -tag_old_static
system vimrc file: "$VIM\vimrc"
user vimrc file: "$HOME\_vimrc"
2nd user vimrc file: "$HOME\vimfiles\vimrc"
3rd user vimrc file: "$VIM\_vimrc"
user exrc file: "$HOME\_exrc"
2nd user exrc file: "$VIM\_exrc"
defaults file: "$VIMRUNTIME\defaults.vim"
Compilation: cl -c /W3 /GF /nologo -I. -Iproto -DHAVE_PATHDEF -DWIN32 -DFEAT_CSCOPE -DFEAT_TERMINAL -DFEAT_SOUND -DFEAT_JOB_CHANNEL -DFEAT_IPV6 -DHAVE_SODIUM -DDYNAMIC_SODIUM -DDYNAMIC_SODIUM_DLL=\"libsodium.dll\" /I "C:\libsodium\include" -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 /source-charset:utf-8 /MP -DHAVE_STDINT_H /Ox /GL -DNDEBUG /Zl /MT /D_CRT_SECURE_NO_DEPRECATE /D_CRT_NONSTDC_NO_DEPRECATE -DFEAT_MBYTE_IME -DDYNAMIC_IME -DDYNAMIC_ICONV -DDYNAMIC_GETTEXT -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL=\"lua54.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL=\"python310.dll\" -DFEAT_MZSCHEME -I "C:\racket\include" -DMZ_PRECISE_GC -DDYNAMIC_MZSCHEME -DDYNAMIC_MZSCH_DLL=\"libracket3m_da32rk.dll\" -DDYNAMIC_MZGC_DLL=\"libracket3m_da32rk.dll\" -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl532.dll\" -DFEAT_RUBY -DDYNAMIC_RUBY -DDYNAMIC_RUBY_DLL=\"x64-msvcrt-ruby300.dll\" -DRUBY_VERSION=30 -DFEAT_HUGE /Fd.\ObjCULYHRZAMD64/ /Zi
Linking: link /nologo /opt:ref /LTCG oldnames.lib kernel32.lib advapi32.lib shell32.lib gdi32.lib comdlg32.lib ole32.lib netapi32.lib uuid.lib user32.lib /machine:AMD64 libcmt.lib /nodefaultlib:lua54.lib /STACK:8388608 /nodefaultlib:python27.lib /nodefaultlib:python310.lib winmm.lib WSock32.lib Ws2_32.lib /PDB:vim.pdb -debug
C:\projects\vim-win32-installer\vim\src>start /wait .\gvim -u NONE -S ..\..\if_ver.vim -c quit
C:\projects\vim-win32-installer\vim\src>type if_ver.txt
*** Interface versions ***
Lua:
Lua 5.4
MzScheme:
8.3
Perl:
v5.32.1
Python 2:
2.7.17 (v2.7.17:c2f86d86e6, Oct 19 2019, 21:01:17) [MSC v.1500 64 bit (AMD64)]
Python 3:
3.10.0 (tags/v3.10.0:b494f59, Oct 4 2021, 19:00:18) [MSC v.1929 64 bit (AMD64)]
Ruby:
3.0.2
Tcl:
Error detected while processing command line..script C:\projects\vim-win32-installer\if_ver.vim:
line 20:
E319: Sorry, the command is not available in this version: tcl puts [info patchlevel]


Best,
Christian
--
Ein Mann ohne eine Frau ist wie eine Statue ohne Tauben.

[Yegappan Lakshmanan]

Hi Christian,

On Tue, Apr 5, 2022 at 9:32 AM Christian Brabandt <cbl...@256bit.org> wrote:
>
>
> On Di, 05 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Chris,
> >
> > On Tue, Apr 5, 2022 at 2:45 AM Christian Brabandt <cbl...@256bit.org> wrote:
> > >
> > > Hi,
> > > since the recent addition of the new lsp feature into vim, the test
> > > Test_channel_lsp_mode() keeps on failing. See a log e.g. here:
> > > https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/43077142/job/a5x2ss0xx1e1un4t
> > >
> > > @Yegappan, do you know what is going wrong there?
> > >
> > > It would be great to have this fixed, so that we can continue building
> > > and providing Windows binaries.
> > >
> >
> > I went through the logs and couldn't figure out why the LSP test is failing.
> > The same test passes in the Vim appveyor build
> > (https://ci.appveyor.com/project/chrisbra/vim/history) and on my local windows
> > system. Is there a python version difference between the Vim appveyor build
> > and this build?
>
> It should be using python 3.10, that is downloaded separately and it is
> using MVC to build.
>

I am not able to reproduce this problem using Python 3.10 on MS-Windows.
Can you run the CI test with the attached patch? This will help me in debugging
this issue.

Thanks,
Yegappan

[Christian Brabandt]

Hi Yegappan,
sure. Let me temporarily commit this. Log's should be there then after
midnight CEST.

Thanks
Chris

Mit freundlichen Grüßen
Christian
--
Die Frage, wer an die Macht kommen soll, ist falsch gestellt. Es
genügt, wenn eine schlechte Regierung abgewählt werden kann.
-- Karl Popper

[Christian Brabandt]

Hi,
since the recent addition of the new lsp feature into vim, the test
Test_channel_lsp_mode() keeps on failing. See a log e.g. here:
https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/43077142/job/a5x2ss0xx1e1un4t

@Yegappan, do you know what is going wrong there?

It would be great to have this fixed, so that we can continue building
and providing Windows binaries.

[Yegappan Lakshmanan]

Hi Chris,

On Wed, Apr 6, 2022 at 4:01 PM Christian Brabandt <cbl...@256bit.org> wrote:
>
> Hi,
> since the recent addition of the new lsp feature into vim, the test
> Test_channel_lsp_mode() keeps on failing. See a log e.g. here:
> https://ci.appveyor.com/project/chrisbra/vim-win32-installer/builds/43077142/job/a5x2ss0xx1e1un4t
>
> @Yegappan, do you know what is going wrong there?
>
> It would be great to have this fixed, so that we can continue building
> and providing Windows binaries.
>

Thanks for collecting the logs. I went through the logs. It looks like
the message (with id 110)
sent by Vim is not received by the python server for some reason.
After this happens,
further messages sent by Vim are not received by the python server. So
all the subsequent
LSP tests are failing. Interestingly across the three test runs, I see
the same failure.
Unfortunately there is no indication why the python server stopped
receiving the messages.

Till the root cause is found, can we disable the
Test_channel_lsp_mode() test in this build?
Note that these tests are passing in the Vim appveyor and Github
action windows builds.

Regards,
Yegappan

[Christian Brabandt]

On Mi, 06 Apr 2022, Yegappan Lakshmanan wrote:

Yeah I know. Hopefully we'll find out what is causing this eventually.

I made PR to disable the test on the vim/vim-win32-installer repository
for now.

https://github.com/vim/vim-win32-installer/pull/256

Best,
Christian
--
Wenn ein Computer alles kann, dann kann er mich mal kreuzweise.

[Yegappan Lakshmanan]

Can someone else with a Windows system try to reproduce this test failure?
Build GUI Vim and run "make test" and see whether all the tests are passing.

Thanks,
Yegappan

[Yegappan Lakshmanan]

Hi Christian,

On Thu, Apr 7, 2022 at 1:42 AM Christian Brabandt <cbl...@256bit.org> wrote:
>
>

I tried running all the LSP tests using the latest Windows binary
built today (from
the vim-win32-installer release) in my local system and all the tests
are passing.

Regards,
Yegappan

[Christian Brabandt]

On Do, 07 Apr 2022, Yegappan Lakshmanan wrote:

> I tried running all the LSP tests using the latest Windows binary
> built today (from
> the vim-win32-installer release) in my local system and all the tests
> are passing.

Thanks for verifying, Yegappan. No idea what's wrong with the appveyor
environment. At least we have some builds again :) Yeah

Best,
Christian
--
Ich kann nur Schreiben, wenn ich zornig bin.
-- Max von der Grün