[vim/vim] Support clearing and unlinking a highlight group in a single call (PR #9117)

[Yegappan Lakshmanan]

Also fix the highlight test failure in a wide terminal.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/9117

Commit Summary

• Support clearing and unlinking a highlight group in a single call

File Changes

(3 files)

• M src/highlight.c (32)
• M src/testdir/test_highlight.vim (30)
• M src/testdir/test_vim9_builtin.vim (1)

Patch Links:

• https://github.com/vim/vim/pull/9117.patch
• https://github.com/vim/vim/pull/9117.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

[codecov[bot]]

Codecov Report

Merging #9117 (80d0e5a) into master (113cb51) will decrease coverage by 87.67%.
The diff coverage is 0.00%.

❗ Current head 80d0e5a differs from pull request most recent head ae028a1. Consider uploading reports for the commit ae028a1 to get more accurate results

@@             Coverage Diff             @@

##           master    #9117       +/-   ##

===========================================

- Coverage   90.13%    2.45%   -87.68%     

===========================================

  Files         151      149        -2     

  Lines      169289   166374     -2915     

===========================================

- Hits       152588     4089   -148499     

- Misses      16701   162285   +145584     

Flag	Coverage Δ
huge-clang-none	?
huge-gcc-none	?
huge-gcc-testgui	?
huge-gcc-unittests	2.45% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/highlight.c	6.49% <0.00%> (-83.01%)	⬇️
src/float.c	0.00% <0.00%> (-99.22%)	⬇️
src/gui_gtk_f.c	0.00% <0.00%> (-97.43%)	⬇️
src/crypt_zip.c	0.00% <0.00%> (-97.06%)	⬇️
src/cmdhist.c	0.00% <0.00%> (-97.03%)	⬇️
src/sha256.c	0.00% <0.00%> (-96.94%)	⬇️
src/evalbuffer.c	0.00% <0.00%> (-96.88%)	⬇️
src/textprop.c	0.00% <0.00%> (-96.84%)	⬇️
src/match.c	0.00% <0.00%> (-96.76%)	⬇️
src/libvterm/src/rect.h	0.00% <0.00%> (-96.56%)	⬇️
... and 138 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113cb51...ae028a1. Read the comment docs.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 059af3c Add support for setting default highlight group attributes and to force creation of a link

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 1b7b47e Modify hlget() to return default boolean item for a default link

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• ada7cbb Support clearing and unlinking a highlight group in a single call.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Bram Moolenaar]

I only just noticed this PR fixes the wide terminal test failure. Perhaps 8.2.3592 needs to be reverted?

[Yegappan Lakshmanan]

Hi Bram,

On Sat, Nov 13, 2021 at 10:54 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

I only just noticed this PR fixes the wide terminal test failure. Perhaps 8.2.3592 needs to be reverted?

Yes. I will merge the changes to my PR and update it.

- Yegappan

 

[vim-dev ML]

Hi Bram,

On Sat, Nov 13, 2021 at 10:54 AM Bram Moolenaar ***@***.***>

wrote:

> I only just noticed this PR fixes the wide terminal test failure. Perhaps
> 8.2.3592 needs to be reverted?
>
>
>
Yes. I will merge the changes to my PR and update it.

- Yegappan

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 396450a Support clearing and unlinking a highlight group in a single call. Add support for setting default highlight group attributes and to force creation of a link.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 97b0ebb Support clearing and unlinking a highlight group in a single call. Add support for setting default highlight group attributes and to force creation of a link.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Yegappan Lakshmanan]

Hi Bram,

On Sat, Nov 13, 2021 at 10:54 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:

I only just noticed this PR fixes the wide terminal test failure. Perhaps 8.2.3592 needs to be reverted?

I have updated the PR to replace these changes.

Regards,

Yegappan 

[vim-dev ML]

Hi Bram,

On Sat, Nov 13, 2021 at 10:54 AM Bram Moolenaar ***@***.***>

wrote:

> I only just noticed this PR fixes the wide terminal test failure. Perhaps
> 8.2.3592 needs to be reverted?
>
>
>
I have updated the PR to replace these changes.

Regards,
Yegappan

[Yegappan Lakshmanan]

@yegappan pushed 2 commits.

• 08a8487 Support clearing and unlinking a highlight group in a single call. Add support for setting default highlight group attributes and to force creation of a link.
• 1cef64e Update option name in comment

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• eaaf46e Support clearing and unlinking a highlight group in a single call. Add support for setting default highlight group attributes and to force creation of a link.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub.

[Bram Moolenaar]

Closed #9117 via 2a16dc6.

—
You are receiving this because you commented.