Patch 7.3.635

43 views
Skip to first unread message

Bram Moolenaar

unread,
Aug 23, 2012, 7:29:08 AM8/23/12
to vim...@googlegroups.com

Patch 7.3.635
Problem: Issue 21: System call during startup sets 'lines' to a wrong
value. (Karl Yngve)
Solution: Don't set the shell size while the GUI is still starting up.
(Christian Brabandt)
Files: src/ui.c


*** ../vim-7.3.634/src/ui.c 2012-07-10 16:49:08.000000000 +0200
--- src/ui.c 2012-08-23 13:25:26.000000000 +0200
***************
*** 298,303 ****
--- 298,306 ----
int retval;

#ifdef FEAT_GUI
+ if (gui.starting)
+ /* possibly a system call during startup, check later */
+ return OK;
if (gui.in_use)
retval = gui_get_shellsize();
else
*** ../vim-7.3.634/src/version.c 2012-08-23 12:58:56.000000000 +0200
--- src/version.c 2012-08-23 13:27:00.000000000 +0200
***************
*** 721,722 ****
--- 721,724 ----
{ /* Add new patch number below this line */
+ /**/
+ 635,
/**/

--
ARTHUR: This new learning amazes me, Sir Bedevere. Explain again how sheep's
bladders may be employed to prevent earthquakes.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Christian J. Robinson

unread,
Aug 23, 2012, 3:06:58 PM8/23/12
to vim...@googlegroups.com
On Thu, 23 Aug 2012, Bram Moolenaar wrote:

> Patch 7.3.635
> Problem: Issue 21: System call during startup sets 'lines' to a wrong
> value. (Karl Yngve)
> Solution: Don't set the shell size while the GUI is still starting up.
> (Christian Brabandt)
> Files: src/ui.c

Now with gVim under Windows, starting Vim maximized doesn't properly
initialize the screen width/height. See:
http://christianrobinson.name/temp/VimHeightWidthProblem.png

- Christian

--
Funny, I don't remember being absent minded.
Christian J. Robinson <hep...@gmail.com> http://christianrobinson.name/

Bram Moolenaar

unread,
Aug 23, 2012, 4:56:57 PM8/23/12
to Christian J. Robinson, vim...@googlegroups.com

Christian J. Robinson wrote:

> On Thu, 23 Aug 2012, Bram Moolenaar wrote:
>
> > Patch 7.3.635
> > Problem: Issue 21: System call during startup sets 'lines' to a wrong
> > value. (Karl Yngve)
> > Solution: Don't set the shell size while the GUI is still starting up.
> > (Christian Brabandt)
> > Files: src/ui.c
>
> Now with gVim under Windows, starting Vim maximized doesn't properly
> initialize the screen width/height. See:
> http://christianrobinson.name/temp/VimHeightWidthProblem.png

Hmm, perhaps instead of just returning we should set a flag so that the
shell size is obtained once the GUI has started.

--
MAN: You don't frighten us, English pig-dog! Go and boil your bottoms,
son of a silly person. I blow my nose on you, so-called Arthur-king,
you and your silly English K...kaniggets.
He puts hands to his ears and blows a raspberry.
Reply all
Reply to author
Forward
0 new messages