[vim/vim] Add tiltfile filetype (Issue #19214)
Luis Davim
luisdavim created an issue (vim/vim#19214)Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
tiltfile is not a recognised filetype
Describe the solution you'd like
Tiltfiles should be recognised and use starlark as their syntax.
Describe alternatives you've considered
Adding file detection directly in my configuration.
Additional context
References:
- https://docs.tilt.dev/api.html
- nvim-treesitter/nvim-treesitter#8447
- https://github.com/nvim-lua/plenary.nvim/blob/master/data/plenary/filetypes/base.lua#L736
- https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/configs/tilt_ls.lua
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19214)This report is a bit confusing, please be more precise
tiltfile is not a recognised filetype
So what makes a tiltfile? An extension? The content?
Tiltfiles should be recognised and use starlark as their syntax.
It should use starlark filetype? Or a different filetype?
Feel free to create a PR to add proper filetype support for tiltfile. do a git log --grep filetype: to find examples of such a change.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Luis Davim
luisdavim left a comment (vim/vim#19214)Hi, sorry for the confusion.
I meant that vim does not recognise tiltfiles as their own file type.
Tiltfiles are written in starlark and named Tiltfile or with an extension like localdev.tiltfile. Kind of like what happens with Dockerfile.
When loading these the syntax should be set as starlark but the filetype should be tiltfile because these would have their own identity, like for example both bazel and tilt use starlark but each have their own LSP server and DSL.
This is why I shared some links to illustrate what I meant.
I'll open a PR for this. Thanks.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Luis Davim
luisdavim left a comment (vim/vim#19214)BTW, I'm not sure if something should be done regarding the ftplugin and syntax. Both bazel and tilt use starlark, but I don't see a starlark ftplugin nor syntax, though bzl has its own ftplugin and syntax.
Maybe that ftplugin and syntax should be renamed to starlark and both tilt and bazel files should use it. But I'm not sure how to do that or even if that should be done.
For now I'm mostly interested in the filetype being detected and I think the PR I did covers that.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.