[vim/vim] Renamed dsl syntax and filetype to dsssl. (#8766)
Bastian Venthur
DSSSL stands for Document Style Semantics and Specification Language
(https://en.wikipedia.org/wiki/Document_Style_Semantics_and_Specification_Language)
-- and .dsl is just the file extension associated with it.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/8766
Commit Summary
- Renamed dsl syntax and filetype to dsssl.
File Changes
- M runtime/filetype.vim (4)
- R runtime/syntax/dsssl.vim (2)
- M src/testdir/test_filetype.vim (2)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
codecov[bot]
Codecov Report
Merging #8766 (d84812f) into master (ccfb7c6) will decrease coverage by
87.68%.
The diff coverage isn/a.
❗ Current head d84812f differs from pull request most recent head a09d8c0. Consider uploading reports for the commit a09d8c0 to get more accurate results
@@ Coverage Diff @@ ## master #8766 +/- ## =========================================== - Coverage 90.14% 2.46% -87.69% =========================================== Files 151 149 -2 Lines 170684 165429 -5255 =========================================== - Hits 153870 4072 -149798 - Misses 16814 161357 +144543
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 2.46% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/float.c | 0.00% <0.00%> (-99.22%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-97.54%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-97.06%) |
⬇️ |
| src/match.c | 0.00% <0.00%> (-96.98%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-96.94%) |
⬇️ |
| src/evalbuffer.c | 0.00% <0.00%> (-96.92%) |
⬇️ |
| src/textprop.c | 0.00% <0.00%> (-96.85%) |
⬇️ |
| src/cmdhist.c | 0.00% <0.00%> (-96.76%) |
⬇️ |
| src/debugger.c | 0.00% <0.00%> (-96.62%) |
⬇️ |
| src/libvterm/src/rect.h | 0.00% <0.00%> (-96.56%) |
⬇️ |
| ... and 137 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ccfb7c6...a09d8c0. Read the comment docs.
Bram Moolenaar
Although the name "dsssl" would be better, is the name "dsl" conflicting with another language?
If not then it's better to keep using the old name, otherwise people relying on it will need to fix things.
Bastian Venthur
I don't know if it is conflicting with another language, but I think it is a bug to name "DSSSL" "DSL", probably due to the file extension being .dsl. In context of languages, DSL usually means domain-specific language (but for that no syntax exists :) so that would be an argument for renaming, but I see you point regarding backwards compatibility.
Bram Moolenaar
Being backwards compatible is more important than having exactly the right name.
We have several other filetypes that are using the file name extension rather than the actual language used.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Bram Moolenaar
Closed #8766.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.