Link error in Small build with Athena GUI after applying patches 4547 and 4548: is this intended?

[Tony Mechelynck]

IOW: does the Athena GUI (which I attempted to build) require support
of the NeXTaw GUI (which has been removed? Or is it "only" due to a
misplaced #ifdef?
I haven't (yet) tried to do a full rebuild by means of "make reconfig".

[...]
config.status: auto/config.h is unchanged
creating auto/pathdef.c
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
-fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/pathdef.o
auto/pathdef.c
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
-fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/userfunc.o
userfunc.c
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
-fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 version.c -o
objects/version.o
link.sh: $LINK_AS_NEEDED set to 'yes': invoking linker directly.
gcc -L/usr/local/lib -Wl,--as-needed -o vim-small
objects/alloc.o objects/arabic.o objects/arglist.o objects/autocmd.o
objects/beval.o objects/buffer.o objects/change.o objects/blob.o
objects/blowfish.o objects/cindent.o objects/clientserver.o
objects/clipboard.o objects/cmdexpand.o objects/cmdhist.o
objects/crypt.o objects/crypt_zip.o objects/debugger.o objects/dict.o
objects/diff.o objects/digraph.o objects/drawline.o
objects/drawscreen.o objects/edit.o objects/eval.o
objects/evalbuffer.o objects/evalfunc.o objects/evalvars.o
objects/evalwindow.o objects/ex_cmds.o objects/ex_cmds2.o
objects/ex_docmd.o objects/ex_eval.o objects/ex_getln.o
objects/fileio.o objects/filepath.o objects/findfile.o objects/float.o
objects/fold.o objects/getchar.o objects/gui_xim.o objects/hardcopy.o
objects/hashtab.o objects/help.o objects/highlight.o
objects/if_cscope.o objects/if_xcmdsrv.o objects/indent.o
objects/insexpand.o objects/list.o objects/locale.o objects/map.o
objects/mark.o objects/match.o objects/mbyte.o objects/memline.o
objects/menu.o objects/misc1.o objects/misc2.o objects/mouse.o
objects/move.o objects/normal.o objects/ops.o objects/option.o
objects/optionstr.o objects/os_unix.o objects/pathdef.o
objects/popupmenu.o objects/popupwin.o objects/profiler.o
objects/pty.o objects/quickfix.o objects/regexp.o objects/register.o
objects/screen.o objects/scriptfile.o objects/search.o
objects/session.o objects/sha256.o objects/sign.o objects/sound.o
objects/spell.o objects/spellfile.o objects/spellsuggest.o
objects/strings.o objects/syntax.o objects/tag.o objects/term.o
objects/terminal.o objects/testing.o objects/textformat.o
objects/textobject.o objects/textprop.o objects/time.o
objects/typval.o objects/ui.o objects/undo.o objects/usercmd.o
objects/userfunc.o objects/version.o objects/vim9cmds.o
objects/vim9compile.o objects/vim9execute.o objects/vim9expr.o
objects/vim9instr.o objects/vim9script.o objects/vim9type.o
objects/viminfo.o objects/window.o objects/bufwrite.o objects/gui.o
objects/gui_motif.o objects/gui_x11.o objects/gui_beval.o
objects/gui_xmdlg.o objects/gui_xmebw.o objects/charset.o
objects/json.o objects/main.o objects/memfile.o objects/message.o
-lXm -lXt -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE -lm -ltinfo
-lelf -lselinux -lacl -lattr -lgpm -ldl
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
objects/gui_x11.o: undefined reference to symbol
'_XEditResCheckMessages'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
/usr/lib64/libXmu.so.6: error adding symbols: DSO missing from command
line
collect2: error: ld returned 1 exit status
link.sh: Linking failed
make: *** [Makefile:2111: vim-small] Error 1
exit status 2
Sat 12 Mar 00:00:18 CET 2022


Best regards,
Tony.

[Bram Moolenaar]

Tony wrote:

> IOW: does the Athena GUI (which I attempted to build) require support
> of the NeXTaw GUI (which has been removed? Or is it "only" due to a
> misplaced #ifdef?
> I haven't (yet) tried to do a full rebuild by means of "make reconfig".
>
> [...]

> objects/gui_x11.o: undefined reference to symbol
> '_XEditResCheckMessages'

I don't get this error when building with Motif. Check
src/autoconfig.h, for me it has this line:

/* #undef HAVE_X11_XMU_EDITRES_H */

If you don't have it commented out, then these lines in gui_x11.c should
be used:

#ifdef HAVE_X11_XMU_EDITRES_H
# include <X11/Xmu/Editres.h>
#endif

And in that file _XEditResCheckMessages is declared.
Maybe "make reconfig" helps?

--
hundred-and-one symptoms of being an internet addict:
237. You tattoo your email address on your forehead.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///