[vim/vim] doc(INSTALLpc): Updated Ruby config.h instructions (PR #13807)

Cthulhux

unread,

Jan 2, 2024, 6:31:01 AM1/2/24

to vim/vim, Subscribed

RubyInstaller will want different directories. Updated.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/13807

Commit Summary

bdda67d doc(INSTALLpc): Updated Ruby config.h instructions

File Changes

(1 file)

M src/INSTALLpc.txt (4)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Jan 2, 2024, 8:02:50 AM1/2/24

to vim/vim, Subscribed

@k-takata commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

config.h should be placed at C:\RubyXY\include\ruby-X.Y.0\i386-mswin32_140\config.h (32-bit) or C:\RubyXY-x64\include\ruby-X.Y.0\x64-mswin64_140\config.h (64-bit), not at C:\RubyXY{,-x64}\include\ruby-X.Y.0\ruby\config.h.
The original commands correctly copy them.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Cthulhux

unread,

Jan 2, 2024, 8:06:49 AM1/2/24

to vim/vim, Subscribed

@dertuxmalwieder commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

That leads - at least on my machine ... - to an error that config.h could not be found. The updated commands fixes that for me.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Jan 2, 2024, 8:23:48 AM1/2/24

to vim/vim, Subscribed

@k-takata commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

Some of the build options might not be correctly set? (E.g. RUBY_API_VER_LONG, RUBY_PLATFORM)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Cthulhux

unread,

Jan 2, 2024, 8:30:45 AM1/2/24

to vim/vim, Subscribed

@dertuxmalwieder commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

The problem is that Ruby's own internal/config.h (used by most Ruby header files) explicitly requires a ruby/config.h...

--> https://github.com/ruby/ruby/blob/5124f9ac7513eb590c37717337c430cb93caa151/include/ruby/internal/config.h#L22

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Jan 2, 2024, 9:14:40 AM1/2/24

to vim/vim, Subscribed

@k-takata commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

config.h should be placed at C:\RubyXY\include\ruby-X.Y.0\i386-mswin32_140\config.h (32-bit) or C:\RubyXY-x64\include\ruby-X.Y.0\x64-mswin64_140\config.h (64-bit),

Sorry, the correct paths are:
32-bit: C:\RubyXY\include\ruby-X.Y.0\i386-mswin32_140\ruby\config.h
64-bit: C:\RubyXY-x64\include\ruby-X.Y.0\x64-mswin64_140\ruby\config.h

C:\RubyXY\include\ruby-X.Y.0\i386-mswin32_140 or C:\RubyXY-x64\include\ruby-X.Y.0\x64-mswin64_140 is specified as an include directory by the -I option in the makefile.
So, the compiler should be able to find ruby/config.h.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Cthulhux

unread,

Jan 2, 2024, 9:25:36 AM1/2/24

to vim/vim, Subscribed

@dertuxmalwieder commented on this pull request.

In src/INSTALLpc.txt:

> -      xcopy /s .ext\include C:\Ruby24\include\ruby-2.4.0
+      xcopy /s .ext\include\i386-mswin32_140\config.h C:\Ruby24\include\ruby-2.4.0\ruby
 
     For 64-bit version:
 
-      xcopy /s .ext\include C:\Ruby24-x64\include\ruby-2.4.0
+      xcopy /s .ext\include\x64-mswin64_140 C:\Ruby24-x64\include\ruby-2.4.0\ruby

Indeed, it does. Turns out it was a configuration mistake on my side. 🤦‍♂️
Sorry.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Cthulhux

unread,

Jan 2, 2024, 9:25:36 AM1/2/24

to vim/vim, Subscribed

Closed #13807.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward