[vim/vim] Add support for fuzzy completion to command-line completion (PR #9803)
Yegappan Lakshmanan
Fuzzy completion is support for the following: buffer names, argument list, autocmd groups/events, built-in command
names, environment variables, built-in and user defined function names, highlight group names, menu names,
syntax group names, and sub options for commands.
Fuzzy completion is not supported for file names and directory names.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/9803
Commit Summary
- 64c5e0e Add support for command completion using fuzzy matches.
File Changes
(13 files)
- M runtime/doc/options.txt (5)
- M src/buffer.c (167)
- M src/cmdexpand.c (121)
- M src/option.c (190)
- M src/option.h (1)
- M src/optionstr.c (2)
- M src/proto/cmdexpand.pro (1)
- M src/proto/option.pro (2)
- M src/proto/search.pro (3)
- M src/search.c (134)
- M src/structs.h (8)
- M src/testdir/gen_opt_test.vim (2)
- M src/testdir/test_cmdline.vim (268)
Patch Links:
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #9803 (64c5e0e) into master (d56eb65) will increase coverage by
1.19%.
The diff coverage is68.33%.
@@ Coverage Diff @@ ## master #9803 +/- ## ========================================== + Coverage 81.83% 83.02% +1.19% ========================================== Files 167 153 -14 Lines 186265 174110 -12155 Branches 41947 39402 -2545 ========================================== - Hits 152421 144550 -7871 + Misses 21456 17339 -4117 + Partials 12388 12221 -167
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.15% <67.91%> (-0.01%) |
⬇️ |
| huge-gcc-none | ? |
|
| huge-gcc-testgui | 80.95% <66.95%> (-0.02%) |
⬇️ |
| huge-gcc-unittests | 2.02% <0.00%> (-0.01%) |
⬇️ |
| linux | 83.02% <68.33%> (-0.74%) |
⬇️ |
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/optionstr.c | 90.76% <ø> (+0.19%) |
⬆️ |
| src/option.c | 87.43% <50.76%> (-0.33%) |
⬇️ |
| src/buffer.c | 86.03% <69.11%> (-0.67%) |
⬇️ |
| src/search.c | 85.10% <72.91%> (-0.82%) |
⬇️ |
| src/cmdexpand.c | 90.40% <83.05%> (-0.74%) |
⬇️ |
| src/libvterm/src/rect.h | 0.00% <0.00%> (-96.78%) |
⬇️ |
| src/libvterm/src/state.c | 38.86% <0.00%> (-50.77%) |
⬇️ |
| src/libvterm/include/vterm.h | 0.00% <0.00%> (-44.45%) |
⬇️ |
| src/libvterm/src/keyboard.c | 47.36% <0.00%> (-40.27%) |
⬇️ |
| src/libvterm/src/pen.c | 48.81% <0.00%> (-35.46%) |
⬇️ |
| ... and 133 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update d56eb65...64c5e0e. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Have some people tried this out? How well does it work?
The help should say a bit more about what "fuzzy" means for this. Something like ordering matches by "best match" instead of alphabetical?
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Have some people tried this out?
How well does it work?
The help should say a bit more about what "fuzzy" means for this. Something like ordering matches by "best match" instead of alphabetical?
vim-dev ML
On Sat, Feb 19, 2022 at 11:36 AM Bram Moolenaar ***@***.***>
wrote:
> Have some people tried this out?
>
No. It will be good if others can try this out and give some feedback.
How well does it work?
>
The help should say a bit more about what "fuzzy" means for this. Something
> like ordering matches by "best match" instead of alphabetical?
>
>
>
I have updated the help text.
Regards,
Yegappan
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
<yega...@gmail.com> wrote:
>
> Hi Bram,
>
> On Sat, Feb 19, 2022 at 11:36 AM Bram Moolenaar <vim-dev...@256bit.org> wrote:
>>
>> Have some people tried this out?
>
> No. It will be good if others can try this out and give some feedback.
>
1. Buffer name completion for the ":buffer", ":sbuffer", ":bdelete",
":bwipeout", ":bunload", ":checktime",
"sign place file=" commands and user defined commands with
"-complete=buffer" argument.
2. Built-in and user defined Ex command names.
3. Option names in the ":set" command
4. Variable and function names in a Vim expression
5. Autocmd group and event names.
6. Environment variable names.
7. Highlight group name
8. Menu names
9. Syntax group names
It is not supported for file/directory names, tag names and color scheme names.
- Yegappan
vim-dev ML
***@***.***> wrote:
>
> Hi Bram,
>
>>
>> Have some people tried this out?
>
> No. It will be good if others can try this out and give some feedback.
>
Currently the cmdline fuzzy completion works in the following cases.
1. Buffer name completion for the ":buffer", ":sbuffer", ":bdelete",
":bwipeout", ":bunload", ":checktime",
"sign place file=" commands and user defined commands with
"-complete=buffer" argument.
2. Built-in and user defined Ex command names.
3. Option names in the ":set" command
4. Variable and function names in a Vim expression
5. Autocmd group and event names.
6. Environment variable names.
7. Highlight group name
8. Menu names
9. Syntax group names
It is not supported for file/directory names, tag names and color scheme names.
- Yegappan
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Maxim Kim
Yegappan Lakshmanan
On Sun, Feb 20, 2022 at 1:03 AM Maxim Kim <hab...@gmail.com> wrote:
>
> > It is not supported for file/directory names, tag names and color scheme names.
>
> Is there a reason not to support file/directory names?
>
this function stack, the search pattern gets mangled (to add wildcard characters
and escape other special characters). So a lot of code changes are needed to
add fuzzy completion for file name/directory names. I may look at this after
adding fuzzy completion for tag names.
Regards,
Yegappan
Maxim Kim
Shane-XB-Qian
Have some people tried this out? How well does it work?
there was a try in the past, check #7872 around the bottom of that ticket.
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Yegappan Lakshmanan
Bram Moolenaar
Looks like comments have quieted down, let me include this now.
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Maxim Kim
It works okay but results are not that useful as I thought they would be.
For example, I have a FixSpaces user command and when I try to find it with :fi<tab> or :Fi<Tab> I get following:
It is really deep down the list:
PS, :fs finds :FixSpaces right away, which is convenient indeed.
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Maxim Kim
I also have :Sy command and whey I do :sy<tab>
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Maxim Kim
And this is indeed strange...
I have my own implementation of fuzzy command selection (using built in functions) and I get this:
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
Yegappan Lakshmanan
vim-dev ML
Thanks for testing and reporting the problem. I found the issue (basically
regular expression matching
is used instead of fuzzy matching for some matches). I will send out a PR.
Regards,
Yegappan
> It works okay but results are not that useful as I thought they would be.
>
> For example, I have a FixSpaces user command and when I try to find it
> with :fi<tab> or :Fi<Tab> I get following:
>
> [image: image]
>
> It is really deep down the list:
> [image: image]
>
> [image: vim-fuzzy]
> <https://user-images.githubusercontent.com/234774/155557091-e243cbae-e872-4a32-8b9f-312a1b70cf43.gif>
>
> PS, :fs finds :FixSpaces right away, which is convenient indeed.
>
>
>
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
And this is indeed strange...
I have my own implementation of fuzzy command selection (using built in functions) and I get this:
vim-dev ML
On Thu, Feb 24, 2022 at 7:50 AM Maxim Kim ***@***.***> wrote:
> And this is indeed strange...
>
> I have my own implementation of fuzzy command selection (using built in
> functions) and I get this:
>
These issues should now be addressed by patch 8.2.4465. Can you try the
latest image?
Thanks,
Yegappan
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Maxim Kim
Yes, it works very well now, thank you!
—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.