Commit: patch 9.1.1073: tests: test_compiler fails on Windows without Maven

3 views
Skip to first unread message

Christian Brabandt

unread,
Feb 3, 2025, 1:00:20 PM2/3/25
to vim...@googlegroups.com
patch 9.1.1073: tests: test_compiler fails on Windows without Maven

Commit: https://github.com/vim/vim/commit/23da16d3d023a20565dc29128208e6cb095231d9
Author: zeertzjq <zeer...@outlook.com>
Date: Mon Feb 3 18:53:28 2025 +0100

patch 9.1.1073: tests: test_compiler fails on Windows without Maven

Problem: tests: test_compiler fails on Windows without Maven.
Solution: Add Xspotbugs directory to $PATH when mvn is not available
(zeertzjq).

closes: #16576

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_compiler.vim b/src/testdir/test_compiler.vim
index d62a4ee3f..99f472401 100644
--- a/src/testdir/test_compiler.vim
+++ b/src/testdir/test_compiler.vim
@@ -417,8 +417,10 @@ func Test_compiler_spotbugs_properties()

" TEST INTEGRATION WITH A SUPPORTED COMPILER PLUGIN.
if filereadable($VIMRUNTIME .. '/compiler/maven.vim')
+ let save_PATH = $PATH
if !executable('mvn')
if has('win32')
+ let $PATH = 'Xspotbugs;' .. $PATH
" This is what ":help executable()" suggests.
call writefile([], 'Xspotbugs/mvn.cmd')
else
@@ -702,6 +704,7 @@ func Test_compiler_spotbugs_properties()

bwipeout
setlocal makeprg=
+ let $PATH = save_PATH
endif

filetype plugin off
diff --git a/src/version.c b/src/version.c
index dd500d157..add59593a 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1073,
/**/
1072,
/**/
Reply all
Reply to author
Forward
0 new messages