[vim/vim] Add compiling with clang as default. (PR #19043)
Łukasz Wieczorek
Hello,
I just tried compiling vim with clang.
It is not stright forward.
Thought it should work like this:
gh repo clone vim/vim
cd ./vim/src/
CC=clang make
sudo make installI added a script and modified Makefile, but in the end would like a simplier solution to use different compiler.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19043
Commit Summary
- 53b9047 Add compiling with clang as default.
File Changes
(2 files)
- A bin/compile.sh (11)
- M src/Makefile (4)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Enno
@Konfekt commented on this pull request.
In bin/compile.sh:
> @@ -0,0 +1,11 @@ +#!/usr/bin/env fish
Wouldn't bash be a more common choice?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
In src/Makefile:
> @@ -254,7 +254,7 @@ #DO NOT CHANGE the next line, we need it for configure to find the compiler #instead of using the default from the "make" program. #Use a line further down to change the value for CC. -CC= +CC=clang
This change is not backwards compatible, as not everyone will have the Clang toolchain installed in their environment.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Łukasz Wieczorek
@wieczorek1990 pushed 1 commit.
- c35aa0e Implement feedback.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Łukasz Wieczorek
@wieczorek1990 commented on this pull request.
In bin/compile.sh:
> @@ -0,0 +1,11 @@ +#!/usr/bin/env fish
Changed to sh.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Łukasz Wieczorek
@wieczorek1990 commented on this pull request.
In src/Makefile:
> @@ -254,7 +254,7 @@ #DO NOT CHANGE the next line, we need it for configure to find the compiler #instead of using the default from the "make" program. #Use a line further down to change the value for CC. -CC= +CC=clang
Right.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Łukasz Wieczorek
@wieczorek1990 commented on this pull request.
In src/Makefile:
> @@ -254,7 +254,7 @@ #DO NOT CHANGE the next line, we need it for configure to find the compiler #instead of using the default from the "make" program. #Use a line further down to change the value for CC. -CC= +CC=clang
Changed. Please look.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Closed #19043.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19043)This is not needed and the provided shell script is trivial. When I am compiling locally, I typically modify the Makefile (as I often need to compile using different feature flags or test with different compilers) and this works just fine. However in your case, you can just use make <args> CC=clang
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.