[vim/vim] Port socketserver to use channels and JSON based protocol (PR #19782)
Foxe Chen
This is not backwards compatible with the old protocol, but I think it is worth it. Using JSON is much simpler instead of trying to understand a custom binary protocol.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19782
Commit Summary
- 400c2bd port socketserver to use channels and JSON based protocol
File Changes
(11 files)
- M src/channel.c (224)
- M src/clientserver.c (10)
- M src/gc.c (3)
- M src/getchar.c (3)
- M src/json.c (2)
- M src/main.c (3)
- M src/proto.h (3)
- M src/proto/channel.pro (4)
- A src/proto/socketserver.pro (6)
- A src/socketserver.c (328)
- M src/structs.h (7)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 27dc4d8 port socketserver to use channels and JSON based protocol
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 3 commits.
- acebaf2 port socketserver to use channels and JSON based protocol
- 2f05b7d remove old socketserver code
- 674f15a update makefile
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- fbe5e5f pass test_clientserver
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- b4fca02 pass test_clientserver
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 7 commits.
- ce61b89 port socketserver to use channels and JSON based protocol
- e18ea9a remove old socketserver code
- 1df670b update makefile
- 0beb98f support poll
- 5d5c9c0 implement reply interface
- d7bc081 change ifdefs for clientserver code
- 7c78864 pass test_clientserver
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 7 commits.
- 15c629f port socketserver to use channels and JSON based protocol
- efc78cc remove old socketserver code
- 7a16a7c update makefile
- dc3c971 support poll
- d78e5a3 implement reply interface
- 8e41afe change ifdefs for clientserver code
- 26d9b72 pass test_clientserver
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 7eaf454 update address parsing
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 3b74962 update address parsing
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 602d848 fix build errors
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman commented on this pull request.
> + if (mch_access((char *)buf, F_OK) != 0)
+ got = true;
+ else
+ {
+ emsg_silent++;
+ channel = channel_open_unix((char *)buf, NULL);
+ emsg_silent--;
+
+ if (channel != NULL)
+ {
+ channel_close(channel, false);
+ channel_clear(channel);
+ }
+ else
+ {
+ mch_remove(buf);
Fixed
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- a203698 fix build errors
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19782)@pemensik Can you test if this PR fixes your issue? Thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 26a7fc8 update makefiles
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.