[patch] tag-jump usability improvement in the help.

116 views
Skip to first unread message

h_east

unread,
Mar 14, 2016, 5:28:44 AM3/14/16
to vim_dev
Hi Bram and list,

Sometimes tag-jump failed in the help.
Because, the help's 'iskeyword' option contains `(`.

Failed case #1:
:h E29
/textwidth
<C-]>

E149: Sorry, no help for ('textwidth'


Failed case #2:
:h viminfo-%
/buflisted
<C-]>

E149: Sorry, no help for ('buflisted'),


I wrote a patch.
When tag starts `('` skip `(` at ":help".
It is very useful :-)
Please include an attached patch.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

help_tagjump_improve.patch

h_east

unread,
Mar 14, 2016, 8:34:09 AM3/14/16
to vim_dev
Hi Bram,

2016-3-14(Mon) 18:28:44 UTC+9 h_east:


> Hi Bram and list,
>
> Sometimes tag-jump failed in the help.
> Because, the help's 'iskeyword' option contains `(`.
>
> Failed case #1:
> :h E29
> /textwidth
> <C-]>
>
> E149: Sorry, no help for ('textwidth'
>
>
> Failed case #2:
> :h viminfo-%
> /buflisted
> <C-]>
>
> E149: Sorry, no help for ('buflisted'),
>
>
> I wrote a patch.
> When tag starts `('` skip `(` at ":help".
> It is very useful :-)
> Please include an attached patch.

If you include the above patch, please include this patch too.
(Workaround inserted space is deleted)

thanks

help_workaround_space_delete.patch

Bram Moolenaar

unread,
Mar 15, 2016, 8:44:36 AM3/15/16
to h_east, vim_dev

Hirohito Higashi wrote:

> Hi Bram and list,
>
> Sometimes tag-jump failed in the help.
> Because, the help's 'iskeyword' option contains `(`.
>
> Failed case #1:
> :h E29
> /textwidth
> <C-]>
>
> E149: Sorry, no help for ('textwidth'
>
>
> Failed case #2:
> :h viminfo-%
> /buflisted
> <C-]>
>
> E149: Sorry, no help for ('buflisted'),
>
>
> I wrote a patch.
> When tag starts `('` skip `(` at ":help".
> It is very useful :-)
> Please include an attached patch.

That is useful, thanks.

We should have a test for this complicated stuff...

--
George: "I just got a new set of golf clubs for my wife!"
John: "Great trade!"

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

h_east

unread,
Mar 15, 2016, 8:54:57 AM3/15/16
to vim_dev, h.eas...@gmail.com
Hi Bram,

2016-3-15(Tue) 21:44:36 UTC+9 Bram Moolenaar:


> Hirohito Higashi wrote:
>
> > Hi Bram and list,
> >
> > Sometimes tag-jump failed in the help.
> > Because, the help's 'iskeyword' option contains `(`.
> >
> > Failed case #1:
> > :h E29
> > /textwidth
> > <C-]>
> >
> > E149: Sorry, no help for ('textwidth'
> >
> >
> > Failed case #2:
> > :h viminfo-%
> > /buflisted
> > <C-]>
> >
> > E149: Sorry, no help for ('buflisted'),
> >
> >
> > I wrote a patch.
> > When tag starts `('` skip `(` at ":help".
> > It is very useful :-)
> > Please include an attached patch.
>
> That is useful, thanks.
>
> We should have a test for this complicated stuff...

Thanks for including my patch!
I begin to write a test from now.
Please wait one hour.

h_east

unread,
Mar 15, 2016, 9:28:59 AM3/15/16
to vim_dev, h.eas...@gmail.com
Hi Bram,

2016-3-15(Tue) 21:54:57 UTC+9 h_east:

Here is a test.

P.S.
Hopefully, following patch also want to include.
https://groups.google.com/d/msg/vim_dev/fH5gsRE-EjE/PtJD1gL-FwAJ

add_test_help_tagjump.patch

Bram Moolenaar

unread,
Mar 15, 2016, 11:36:00 AM3/15/16
to h_east, vim_dev
Thanks. I assume you used "exec" to work around a highlighting problem.
We don't need it for "helpclose".

> P.S.
> Hopefully, following patch also want to include.
> https://groups.google.com/d/msg/vim_dev/fH5gsRE-EjE/PtJD1gL-FwAJ

Already did, will go out with runtime file updates.


--
hundred-and-one symptoms of being an internet addict:
42. Your virtual girlfriend finds a new net sweetheart with a larger bandwidth.

h_east

unread,
Mar 25, 2016, 10:40:45 PM3/25/16
to vim_dev, h.eas...@gmail.com
Hi Bram and list,

I wrote another improved patch for the help tagjump.

If tag contains ({ or ([, Tag is set to terminate the (

It will not require a space after the "function_name(" in the help.
Please include this.

help_tagjump_improve2.patch

h_east

unread,
Mar 26, 2016, 10:49:46 AM3/26/16
to vim_dev, h.eas...@gmail.com
Hi Bram and list,

2016-3-26(Sat) 11:40:45 UTC+9 h_east:


> Hi Bram and list,
>
> I wrote another improved patch for the help tagjump.
>
> If tag contains ({ or ([, Tag is set to terminate the (
>
> It will not require a space after the "function_name(" in the help.
> Please include this.

PS
Current official runtime/doc/tags does not contained tag (' and ({ and ([.
When this patch is included, we can no longer tag-jump above tags in official/unofficial help.
Original `(` command is one of the Text object motions. And it ends the command in the `(`.
So that, `({` and `([` with a user-defined command is defined, we believe that almost no.

Someone, Do you have any opinion?

Thanks

Bram Moolenaar

unread,
Mar 26, 2016, 11:52:57 AM3/26/16
to h_east, vim_dev

Hirohito Higashi wrote:

> Hi Bram and list,
>
> I wrote another improved patch for the help tagjump.
>
> If tag contains ({ or ([, Tag is set to terminate the (
>
> It will not require a space after the "function_name(" in the help.
> Please include this.

Thanks, I'll look into it.

--
hundred-and-one symptoms of being an internet addict:
127. You bring your laptop and cellular phone to church.
Reply all
Reply to author
Forward
0 new messages