[vim/vim] make exists("+cdhome") return 0 on Unix (PR #9331)
zeertzjq
I believe this still allows setting 'cdhome' on all systems without checking.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/9331
Commit Summary
- db96724 make exists("+cdhome") return 0 on Unix
File Changes
(1 file)
- M src/optiondefs.h (4)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
zeertzjq
It also makes the check exists('+cdhome') in optwin.vim no longer always true.
codecov[bot]
Codecov Report
Merging #9331 (db96724) into master (4f16e9d) will decrease coverage by
0.60%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #9331 +/- ## ========================================== - Coverage 90.32% 89.72% -0.61% ========================================== Files 151 150 -1 Lines 172659 171744 -915 ========================================== - Hits 155950 154092 -1858 - Misses 16709 17652 +943
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 89.31% <ø> (ø) |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | 88.34% <ø> (+<0.01%) |
⬆️ |
| huge-gcc-unittests | 2.45% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/libvterm/src/rect.h | 0.00% <0.00%> (-96.56%) |
⬇️ |
| src/libvterm/src/state.c | 43.90% <0.00%> (-45.39%) |
⬇️ |
| src/libvterm/include/vterm.h | 0.00% <0.00%> (-37.50%) |
⬇️ |
| src/libvterm/src/keyboard.c | 55.78% <0.00%> (-32.64%) |
⬇️ |
| src/libvterm/src/pen.c | 52.21% <0.00%> (-32.45%) |
⬇️ |
| src/libvterm/src/encoding.c | 46.53% <0.00%> (-26.74%) |
⬇️ |
| src/libvterm/src/parser.c | 72.50% <0.00%> (-23.34%) |
⬇️ |
| src/libvterm/src/vterm.c | 47.03% <0.00%> (-19.04%) |
⬇️ |
| src/libvterm/src/mouse.c | 45.16% <0.00%> (-3.23%) |
⬇️ |
| src/screen.c | 85.63% <0.00%> (-1.49%) |
⬇️ |
| ... and 18 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 4f16e9d...db96724. Read the comment docs.
Shane-XB-Qian
i am curious why here not mentioned 'Linux', or 'unix-like' could be better? :-)
zeertzjq
This is the terminology used in the help file:
:cd[!] On non-Unix systems when 'cdhome' is off: Print the
current directory name.
Otherwise: Change the current directory to the home
directory. Clear any window-local directory.
Use |:pwd| to print the current directory on all
Shane-XB-Qian
yea, perhaps the term should be 'non-unix-like' systems, or 'cdhome' just an option for 'MS-Windows', better?
Gary Johnson
> yea, perhaps the term should be 'non-unix-like' systems, or 'cdhome' just an
> option for 'MS-Windows', better?
overwhelmingly in the Vim documentation to refer to Unix or
Unix-like systems generically. It is used 729 times. Additionally,
"non-unix" is used 31 times. "Unix-like" is used only 11 times.
Regards,
Gary
vim-dev ML
Bram Moolenaar
I do not really see a good reason to add this #ifdef.
—
You are receiving this because you commented.
zeertzjq
This line in optwin.vim is currently pointless:
https://github.com/vim/vim/blob/9a4ec5a62632af040c278a189e256043740f5c7f/runtime/optwin.vim#L263
—
You are receiving this because you commented.
Bram Moolenaar
Bram Moolenaar
I'll adjust the option window script.
—
You are receiving this because you commented.