[vim/vim] Cmdline pum doesn't work properly with 'rightleft' (PR #15005)

zeertzjq

unread,

Jun 14, 2024, 10:14:55 PM (13 days ago) Jun 14

to vim/vim, Subscribed

Problem: Cmdline pum doesn't work properly with 'rightleft'.
Solution: Don't use curwin->w_p_rl in cmdline mode in pum_redraw(). Use
a static variable since pum_may_redraw() may be called in any
mode. Also correct positioning of :popup with 'rightleft' and
add test for 'balloonevalterm' with 'rightleft'.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/15005

Commit Summary

148923d Cmdline pum doesn't work properly with 'rightleft'

File Changes

(9 files)

M src/popupmenu.c (84)
A src/testdir/dumps/Test_balloon_eval_term_03.dump (10)
A src/testdir/dumps/Test_mouse_popup_position_01.dump (20)
A src/testdir/dumps/Test_mouse_popup_position_02.dump (20)
A src/testdir/dumps/Test_popup_command_rl.dump (20)
A src/testdir/dumps/Test_wildmenu_pum_rl.dump (10)
M src/testdir/test_balloon.vim (25)
M src/testdir/test_cmdline.vim (18)
M src/testdir/test_popup.vim (38)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 14, 2024, 10:16:30 PM (13 days ago) Jun 14

to vim/vim, Push

@zeertzjq pushed 1 commit.

78fd00f Cmdline pum doesn't work properly with 'rightleft'

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 14, 2024, 10:21:09 PM (13 days ago) Jun 14

to vim/vim, Push

@zeertzjq pushed 1 commit.

1695590 Cmdline pum doesn't work properly with 'rightleft'

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 14, 2024, 10:27:33 PM (13 days ago) Jun 14

to vim/vim, Push

@zeertzjq pushed 1 commit.

147004c Cmdline pum doesn't work properly with 'rightleft'

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 14, 2024, 10:29:06 PM (13 days ago) Jun 14

to vim/vim, Push

@zeertzjq pushed 1 commit.

a00f257 Cmdline pum doesn't work properly with 'rightleft'

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 14, 2024, 10:34:49 PM (13 days ago) Jun 14

to vim/vim, Subscribed

For right-click menu and 'balloonevalterm', using the value of 'rightleft' may not be ideal either, but I'll keep the old behavior of taking 'rightleft' into account in this PR and only correct the positioning. For cmdline completion using 'rightleft' doesn't make sense as the cmdline is always left-to-right.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jun 15, 2024, 9:37:42 AM (12 days ago) Jun 15

to vim/vim, Subscribed

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jun 15, 2024, 9:38:55 AM (12 days ago) Jun 15

to vim/vim, Subscribed

Closed #15005 via 883018f.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward