[vim/vim] runtime(ics): add icalendar ftplugin and syntax plugins (PR #21356)
Anakin Childerhose
Add syntax and ftplugins for iCalendar ics files.
These commits provide matchit, folding, and syntax highlighting for ics files.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21356
Commit Summary
- 77cf0a4 runtime(ics): add ftplugin support for iCalendar files
- e45374a runtime(ics): add syntax highlighting for ics iCalendar files
File Changes
(13 files)
- M .github/MAINTAINERS (2)
- M runtime/doc/filetype.txt (11)
- M runtime/doc/syntax.txt (16)
- M runtime/filetype.vim (3)
- A runtime/ftplugin/ics.vim (53)
- A runtime/syntax/ics.vim (115)
- A runtime/syntax/testdir/dumps/ics_00.dump (20)
- A runtime/syntax/testdir/dumps/ics_01.dump (20)
- A runtime/syntax/testdir/dumps/ics_02.dump (20)
- A runtime/syntax/testdir/dumps/ics_03.dump (20)
- A runtime/syntax/testdir/input/ics.ics (60)
- A runtime/syntax/testdir/input/setup/ics.vim (3)
- M src/testdir/test_filetype.vim (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#21356)Thanks for the particularly complete PR.
Looking at the RFC it seems icalendar would be a better filetype name. I don't know the domain though so perhaps ics has meaning beyond just the filename extension?
Could you please address the following small issues:
- use "Last Change:" rather than "Last Revision" in the header? The former is the de facto standard even though I'm aware the latter is in use.
- documentation titles should generally match the filetype, so s/ICALENDAR/ICS/
:highlightcommands are grouped together at the end of the file. I have sympathy for your current layout, and do that myself during development, but there's some value in consistency and the distributed files almost without exception put them last.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Anakin Childerhose
anakin4747 left a comment (vim/vim#21356)Looking at the RFC it seems
icalendarwould be a better filetype name. I don't know the domain though so perhapsicshas meaning beyond just the filename extension?
That makes sense, I have switched to the icalendar filetype
Could you please address the following small issues:
- use "Last Change:" rather than "Last Revision" in the header? The former is the de facto standard even though I'm aware the latter is in use.
Changed to "Last Change" in both icalendar.vim files
- documentation titles should generally match the filetype, so s/ICALENDAR/ICS/
Left as ICALENDAR as now that is the filetype
:highlightcommands are grouped together at the end of the file. I have sympathy for your current layout, and do that myself during development, but there's some value in consistency and the distributed files almost without exception put them last.
I moved highlight commands to after syntax commands
Please let me know if there are any other changes that need to be made,
Thanks for your time and effort!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21356)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.