[vim/vim] GTK: Make popup images account for display scaling (PR #20611)
Foxe Chen
Make popup images account for display scaling in GTK GUI. Unfortunately GTK2 does not seem to have a way to query the scale factor, so this PR does not work for it.
Additionally, clip images if they are bigger than the screen size. Before, if an image was bigger than the screen size, it would go outside the popup window bounds. This fix only applies for the GUI, images in terminal still have this issue, but that requires a more complex change.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20611
Commit Summary
- 4561d0d make popup images account for display scaling
File Changes
(8 files)
- M src/cairo.c (8)
- M src/gui.c (3)
- M src/gui.h (10)
- M src/gui_gtk4.c (20)
- M src/gui_gtk4_da.c (15)
- M src/gui_gtk_x11.c (8)
- M src/popupwin.c (65)
- M src/proto/popupwin.pro (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20611)@chrisbra The popup image feature right now is quite buggy (especially for kitty image graphics protocol). I think it should be made opt in (like the GTK4 GUI) for now until it is stable enough. What do you think? I will try taking my shot at fixing the bugs for this feature.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20611)I don't use that feature, but I agree, if this is too buggy right now, we should opt-out of this by default or even drop it again.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.