Patch 8.2.1036

[Bram Moolenaar]

Patch 8.2.1036
Problem: Popupwin test fails sometimes.
Solution: Use WaitForAssert() instead of a sleep.
Files: src/testdir/test_popupwin.vim


*** ../vim-8.2.1035/src/testdir/test_popupwin.vim 2020-06-20 15:03:34.978136840 +0200
--- src/testdir/test_popupwin.vim 2020-06-22 19:23:14.779285233 +0200
***************
*** 2454,2462 ****
call term_sendkeys(termbuf2, "exit\<CR>")

" Exiting shell closes popup window
call feedkeys("exit\<CR>", 'xt')
" Wait for shell to exit
! sleep 100m
call feedkeys(":quit\<CR>", 'xt')
call assert_equal(origwin, win_getid())
endfunc
--- 2454,2464 ----
call term_sendkeys(termbuf2, "exit\<CR>")

" Exiting shell closes popup window
+ let pupwin = win_getid()
call feedkeys("exit\<CR>", 'xt')
" Wait for shell to exit
! call WaitForAssert({-> assert_notequal(pupwin, win_getid())})
!
call feedkeys(":quit\<CR>", 'xt')
call assert_equal(origwin, win_getid())
endfunc
*** ../vim-8.2.1035/src/version.c 2020-06-22 19:10:51.689755096 +0200
--- src/version.c 2020-06-22 19:24:01.611138833 +0200
***************
*** 756,757 ****
--- 756,759 ----
{ /* Add new patch number below this line */
+ /**/
+ 1036,
/**/

--
"When I die, I want a tombstone that says "GAME OVER" - Ton Richters

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Yegappan Lakshmanan]

Hi,

On Mon, Jun 22, 2020 at 10:24 AM Bram Moolenaar <Br...@moolenaar.net> wrote:

Patch 8.2.1036
Problem:    Popupwin test fails sometimes.
Solution:   Use WaitForAssert() instead of a sleep.
Files:      src/testdir/test_popupwin.vim

After this change, the FreeBSD Cirrus/CI test is failing in Test_popupwin_terminal_buffer().

- Yegappan

 

[Bram Moolenaar]

Yeah, I somehow managed to run the wrong test function when trying out
the change. Fix on the way.

The GUI test sometimes hangs on Travis, and I don't seem to have a way
to figure out where it hangs...

--
VOICE OVER: As the horrendous Black Beast lunged forward, escape for Arthur
and his knights seemed hopeless, when, suddenly ... the animator
suffered a fatal heart attack.
ANIMATOR: Aaaaagh!
VOICE OVER: The cartoon peril was no more ... The Quest for Holy Grail could
continue.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD