[vim/vim] runtime(haskell): add include-search support (PR #19143)
Mateo Gjika
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19143
Commit Summary
- 7cf3302 runtime(haskell): add include-search support
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19143)did you contact the maintainer?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
mateoxh left a comment (vim/vim#19143)did you contact the maintainer?
No, I thought it was possible to do a revision "by the Vim Project" as per the last one.
@alx741 Do you have any objections to the PR? I could also set define which then allows to navigate a haskell codebase using only native Vim features.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#19143)did you contact the maintainer?
No, I thought it was possible to do a revision "by the Vim Project" as per the last one.
In principle that happens after a failed attempt to get maintainer approval.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
mateoxh left a comment (vim/vim#19143)In principle that happens after a failed attempt to get maintainer approval.
Ok, thanks. I don't think he's going to answer then...
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19143)Ok, thanks. I don't think he's going to answer then...
Let's see. If he is not responding here, I'll merge it, because I think the idea is good. But let's wait a few more days. I just want to give the maintainer a chance to review.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Daniel Campoverde
alx741 left a comment (vim/vim#19143)Hey guys, thanks for including me in the loop. The change LGTM!, thank you @mateoxh
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
mateoxh left a comment (vim/vim#19143)Hey guys, thanks for including me in the loop. The change LGTM!, thank you @mateoxh
It's great to see you're still active here. What do you think about adding define as well? I’ve been using this pattern:
setlocal define=^\\%(data\\>\\\|class\\>\\%(.*=>\\)\\?\\\|\\%(new\\)\\?type\\>\\\|\\ze\\k\\+\\s*\\%(::\\\|=\\)\\)
The tricky part is the last group which matches type signatures (a basic go to definition). Since they're not always required I also made it match assignments at the top-level (i.e. those not indented).
I think it works suprisingly well in helping to navigate a codebase using native mappings like [d, [i, [<C-d>, etc.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Daniel Campoverde
alx741 left a comment (vim/vim#19143)Tried it just now and works pretty well, would be a nice inclusion for sure. If you add a commit with it, you have my thumbs up, thanks for working on it!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
@mateoxh pushed 1 commit.
- 14921b9 runtime(haskell): add 'define' option
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
mateoxh left a comment (vim/vim#19143)One more thing. I was also wondering why expandtab isn't enabled by default? See https://errors.haskell.org/messages/GHC-94817/
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.