[vim/vim] po/Makefile: Avoid race over LINGUAS file (PR #10776)
Richard Purdie
The creation of the LINGUAS file is duplicated for each desktop file
which can lead the commands to race against each other. One target might
remove it before another has been able to use it. Rework the makefile to
avoid this as the expense of leaving the file on disk.
Signed-off-by: Richard Purdie richard...@linuxfoundation.org
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10776
Commit Summary
- bfc6d38 po/Makefile: Avoid race over LINGUAS file
File Changes
(1 file)
- M src/po/Makefile (9)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
Well, after this change it leaves the LINGUAS file behind. The documentation isn't very clear, but it seems that the file can't be given another name, so that we would be able to use a different file in each block.
Any way to delete LINGUAS when done?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Dominique Pellé
@brammool wrote:
Well, after this change it leaves the LINGUAS file behind.
LINGUAS is removed in the clean target. So I think the change is fine.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> @brammool wrote:
>
> > Well, after this change it leaves the LINGUAS file behind.
>
> `LINGUAS` is removed in the `clean` target. So I think the change is fine.
Perhaps there is a way to make the targets run sequential.
Perhaps by making gvim.desktop depend on vim.desktop.
Or by joining the two blocks.
It's a bit weird that a tool has an input file for which the name can't
be specified.
--
Send $25.00 for handy leaflet on how to make money by selling leaflets
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> > @brammool wrote:
> >
> > > Well, after this change it leaves the LINGUAS file behind.
> >
> > `LINGUAS` is removed in the `clean` target. So I think the change is fine.
>
> I normally don't type "make clean", as it also deltes the *.mo files.
>
> Perhaps there is a way to make the targets run sequential.
> Perhaps by making gvim.desktop depend on vim.desktop.
> Or by joining the two blocks.
>
> It's a bit weird that a tool has an input file for which the name can't
> be specified.
rule? Then vim.desktop must be done before the other, they can't run at
the same time, right?
- gvim.desktop: gvim.desktop.in $(POFILES)
+ gvim.desktop: gvim.desktop.in $(POFILES) vim.desktop
--
If you feel lonely, try schizophrenia.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
Bram Moolenaar
Can you check if the problem still exists after the recent change to src/po/Makefile ?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Richard Purdie
We haven't seen the issue again since that change so I think we're good, thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Richard Purdie
Closed #10776.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.