[vim/vim] Add lgtm.yml file to prevent lgtm.com parsing tutor.es as ECMAScript (#2844)
Bas van Schaik
I just noticed that lgtm.com tries to parse tutor.es as ECMAScript: https://lgtm.com/projects/g/vim/vim/alerts. This hint should stop it from doing that.
The behaviour of lgtm.com can be tweaked using this lgtm.yml file. More info here: https://lgtm.com/help/lgtm/lgtm.yml-configuration-file
(full disclosure: I'm part of the team that built lgtm.com)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/2844
Commit Summary
- add .lgtm.yml file to prevent tutor.es from being parsed as ECMAScript
File Changes
- A .lgtm.yml (3)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
Codecov
Codecov Report
Merging #2844 into master will decrease coverage by
<.01%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #2844 +/- ## ========================================== - Coverage 75.4% 75.39% -0.01% ========================================== Files 92 92 Lines 134735 134736 +1 ========================================== - Hits 101596 101589 -7 - Misses 33139 33147 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/libvterm/src/state.c | 45.07% <0%> (-0.98%) |
⬇️ |
| src/gui_beval.c | 62.66% <0%> (-0.43%) |
⬇️ |
| src/if_xcmdsrv.c | 84.17% <0%> (-0.36%) |
⬇️ |
| src/os_unix.c | 54.3% <0%> (-0.14%) |
⬇️ |
| src/undo.c | 82.51% <0%> (-0.07%) |
⬇️ |
| src/gui.c | 47.73% <0%> (-0.06%) |
⬇️ |
| src/if_py_both.h | 76.59% <0%> (ø) |
⬆️ |
| src/ex_docmd.c | 75.82% <0%> (+0.01%) |
⬆️ |
| src/gui_gtk_x11.c | 47.73% <0%> (+0.09%) |
⬆️ |
| src/term.c | 60.44% <0%> (+0.15%) |
⬆️ |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 46a53df...52875c4. Read the comment docs.
Bram Moolenaar
There is also a Makefile in that directory. How about this instead:
Format of this file: https://lgtm.com/help/lgtm/lgtm.yml-configuration-file
path_classifiers:
documentation:
- runtime/tutor/tutor*
Bas van Schaik
@brammool: made that change. It actually doesn't matter much: the file classification is only applied after the analysis, so the Makefile is still considered.
Christian Brabandt
@sjvs how long does it usually take until lgtm picks up and analyzes those changes. I see that for #2821 it is still waiting in the "fetching commits" phase https://lgtm.com/projects/g/vim/vim/rev/pr-aa04b34b261763e73568b1c3b7fc1151db1d17b7
Bas van Schaik
Hi @chrisbra! For a codebase like Vim's, I'd expect the LGTM.com analysis to complete within approximately 30-40 minutes. In that time two revisions are analysed, and the results are compared. LGTM then only posts the new and fixed alerts.
Initially LGTM struggled to fetch the commits from the Vim Git repository (also see #2821). We diagnosed the problem yesterday morning and pushed a fix to LGTM.com around 15:00 UTC. The problem was related to processing large numbers of Git tags, like Vim (6858 tags!).
Following that fix, automatic code review in pull requests for Vim is now working. For example, see #2850: a commit was pushed at 23:28:43 UTC, and the analysis status (LGTM 😄) was posted back to the PR at 00:02:29.
Apologies for the slight delay in getting this to work. For the other open PR (#2821), the LGTM.com analysis will kick off again if a new commit is pushed. It'll soon also be able to retry an analysis in case a commit gets stuck (happens rarely, but still).
If there's anything else that doesn't quite look right to you: give me a shout!
(cc @samlanning)
Christian Brabandt
Ah, thanks for the detailed answer!