[vim/vim] highlight.pro doesn't compile (Issue #19568)
Cthulhux
dertuxmalwieder created an issue (vim/vim#19568)Steps to reproduce
Commit 98174ca breaks highlight.pro: Visual Studio throws an error C2143 while parsing line 51.
void update_highlight_overrides(hl_override_T *old, hl_override_T *new, int newlen);
Makes sense: new is not a valid variable name in good old C if compiled with a C++ compiler...
Expected behaviour
It might make sense to rename the variable here.
Version of Vim
9.2
Environment
Windows 11, Visual Studio 2022
Logs and stack traces
...\vim\src\proto\highlight.pro(51): error C2143: Syntaxfehler: Es fehlt ")" vor "new" (Quelldatei wird kompiliert if_ole.cpp) ...\vim\src\proto\highlight.pro(51): error C2143: Syntaxfehler: Es fehlt ";" vor "new" (Quelldatei wird kompiliert if_ole.cpp) ...\vim\src\proto\highlight.pro(51): error C2059: Syntaxfehler: "new" (Quelldatei wird kompiliert if_ole.cpp) ...\vim\src\proto\highlight.pro(51): error C2059: Syntaxfehler: ")" (Quelldatei wird kompiliert if_ole.cpp)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Cthulhux
dertuxmalwieder left a comment (vim/vim#19568)Looks good to me.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19568)#19558 should fix it
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Cthulhux
dertuxmalwieder left a comment (vim/vim#19568)It does. Possible improvement: a more consistent naming scheme ("hl_old"). But this bug can safely be closed now. I'll do so.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Cthulhux
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.