[vim/vim] Don't immediately close the input handle to conpty on EOF (PR #19025)

MURAOKA Taro

unread,

Dec 26, 2025, 10:42:44 AM (2 days ago) Dec 26

to vim/vim, Subscribed

Problem: Conpty terminal process may not start. It causes the following tests to fail in Windows conpty:

Test_terminal_duplicate_eof_arg()
Test_terminal_eof_arg()
Test_terminal_eof_arg_win32_ctrl_z()

To be precise, the process is launched, but immediately after it is launched, the input handle to the console is closed with the EOF of the input, and the console is terminated. When the console is terminated, the associated process is also terminated.

Solution: Do not close the input handle at EOF.

In the Windows pseudo console, input and output handles are closed after the process in the console has terminated. This is not explicitly stated in Microsoft's documentation. However, looking at the code for Windows Terminal, which is presented as a complete example of the pseudo console, it is implemented exactly this way.

See the sample codes below:

The handle that is not closed at EOF is closed when Vim detects the end of the job, so there is no risk of them being forgotten and leaking.

ch_anonymous_pipe, which was used to determine whether a channel was for conpty, was set to TRUE only when conpty was being used. The definition also had the comment // ConPTY attached to it. This name is not very appropriate, but I felt it would be rude to add a new field to channel_T just for this purpose, so I reused it.