[vim/vim] Add out-of-memory check to may_get_cmd_block() (PR #19906)
John Marriott
This PR adds an out-of-memory check to may_get_cmd_block().
Function ga_concat_strings() returns NULL on an out-of-memory condition.
Function may_get_cmd_block() calls ga_concat_strings() and passes it's return value unchecked to it's caller.
When called from function do_autocmd(), this return value is then passed unchecked to expand_sfile() which calls STRLEN() on it.
When called from function ex_command(), this return value is then passed unchecked, via uc_add_command(), to replace_termcodes() which calls STRLEN() on it.
Obviously, both of which will result in attempting to deference a potentially NULL pointer.
This PR changes function may_get_cmd_block() to check the result of ga_concat_strings() and returns it's input value p on a NULL result, just like the function does if ga_copy_string() fails.
Cheers
John
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19906
Commit Summary
- 764a718 Add out-of-memory check to may_get_cmd_block()
File Changes
(1 file)
- M src/usercmd.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.