Found errors in Test_term_mouse_double_click_to_create_tab():

27 views
Skip to first unread message

Elimar Riesebieter

unread,
May 3, 2019, 7:56:45 AM5/3/19
to vim...@googlegroups.com
Hi,

compiling v8.1.1250 within a remote tmux session I get:

Found errors in Test_term_mouse_double_click_to_create_tab():
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=xterm2: Expected 32 but got 0
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=xterm2: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page
1', ' Xtab1', 'Tab page 2', '> Xtab2']
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=sgr: Expected 32 but got 0
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=sgr: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=urxvt: Expected 32 but got 0
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=urxvt: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=dec: Expected 32 but got 0
function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=dec: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
TEST FAILURE


--
From The Collaborative International Dictionary of English v.0.48 [gcide]:
.
arsehole \arse"hole`\ ([aum]rs"h[=o]l`), n.
1. execretory opening at the end of the alimentary canal.

Dominique Pellé

unread,
May 3, 2019, 10:35:19 AM5/3/19
to vim_dev
Elimar Riesebieter <ries...@lxtec.de> wrote:

> Hi,
>
> compiling v8.1.1250 within a remote tmux session I get:
>
> Found errors in Test_term_mouse_double_click_to_create_tab():
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=xterm2: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=xterm2: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page
> 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=sgr: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=sgr: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=urxvt: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=urxvt: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=dec: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=dec: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> TEST FAILURE

The test also always fails for me at 8.1.1250 on Linux x86_64.
The test always passes at 8.1.1.1249.

I'm not using tmux. I'm just running tests in a terminal (xterm or
xfce4-terminal)

Regards

Dominique

Bram Moolenaar

unread,
May 3, 2019, 3:57:00 PM5/3/19
to vim...@googlegroups.com, Elimar Riesebieter

Elimar Riesebieter wrote:

> compiling v8.1.1250 within a remote tmux session I get:
>
> Found errors in Test_term_mouse_double_click_to_create_tab():
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=xterm2: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=xterm2: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page
> 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=sgr: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=sgr: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=urxvt: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=urxvt: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=dec: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=dec: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> TEST FAILURE

I tried running the tests in tmux, but it works fine for me.
Anything else that would matter?

--
ARTHUR: Go on, Bors, chop its head off.
BORS: Right. Silly little bleeder. One rabbit stew coming up.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Dominique Pellé

unread,
May 4, 2019, 2:47:36 AM5/4/19
to vim_dev, Elimar Riesebieter
Bram Moolenaar <Br...@moolenaar.net> wrote:

> Elimar Riesebieter wrote:
>
> > compiling v8.1.1250 within a remote tmux session I get:
> >
> > Found errors in Test_term_mouse_double_click_to_create_tab():
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=xterm2: Expected 32 but got 0
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=xterm2: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page
> > 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=sgr: Expected 32 but got 0
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=sgr: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=urxvt: Expected 32 but got 0
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=urxvt: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=dec: Expected 32 but got 0
> > function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=dec: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> > TEST FAILURE
>
> I tried running the tests in tmux, but it works fine for me.
> Anything else that would matter?

For me the test error happens even without tmux anyway.
Test always fails.
I don't know why yet, but this change which comments out
a few lines makes the test pass:

$ git diff test_termcodes.vim
diff --git a/src/testdir/test_termcodes.vim b/src/testdir/test_termcodes.vim
index aef9814af..f6e50c2ae 100644
--- a/src/testdir/test_termcodes.vim
+++ b/src/testdir/test_termcodes.vim
@@ -21,11 +21,11 @@ else
endif

" netterm only supports left click
-if has('mouse_netterm')
- let s:ttymouse_netterm = ['netterm']
-else
+"if has('mouse_netterm')
+" let s:ttymouse_netterm = ['netterm']
+"else
let s:ttymouse_netterm = []
-endif
+"endif

Of course I'm not suggesting we do that, but this just
shows that somehow 'netterm' breaks the test.

To Bram: could it be that for you :echo has('mouse_netterm')
gives 0 so the test would be disabled for you? For me it
gives 1.

Regards
Dominique

Elimar Riesebieter

unread,
May 4, 2019, 5:27:07 AM5/4/19
to vim_dev
* Dominique Pellé <dominiq...@gmail.com> [2019-05-04 08:46 +0200]:
I confirm `:echo has('mouse_netterm')` gives 1 for me too.

--
The path to source is always uphill!
-unknown-

Bram Moolenaar

unread,
May 4, 2019, 8:05:33 AM5/4/19
to vim...@googlegroups.com, Dominique Pellé, Elimar Riesebieter
I do have netterm support, that's how I verified the test works.
It also passes on CI.

It might be that you have other mouse support interfering. Perhaps
check them all:
echo 'mouse: ' .. has('mouse')
echo 'mouse_dec: ' .. has('mouse_dec')
echo 'mouse_gpm: ' .. has('mouse_gpm')
echo 'mouse_netterm: ' .. has('mouse_netterm')
echo 'mouse_pterm: ' .. has('mouse_pterm')
echo 'mouse_sysmouse: ' ..has('mouse_sysmouse')
echo 'mouse_sgr: ' .. has('mouse_sgr')
echo 'mouse_urxvt: ' .. has('mouse_urxvt')
echo 'mouse_xterm: ' .. has('mouse_xterm')
echo 'mouseshape: ' .. has('mouseshape')

I get:
mouse: 1
mouse_dec: 1
mouse_gpm: 0
mouse_netterm: 1
mouse_pterm: 0
mouse_sysmouse: 0
mouse_sgr: 1
mouse_urxvt: 1
mouse_xterm: 1
mouseshape: 1


--
Lose weight, NEVER Diet again with
The "Invisible Weight Loss Patch"
(spam e-mail)

Elimar Riesebieter

unread,
May 4, 2019, 9:11:52 AM5/4/19
to Bram Moolenaar, vim...@googlegroups.com, Dominique Pellé
* Bram Moolenaar <Br...@moolenaar.net> [2019-05-04 14:05 +0200]:
Well configure with --disable-gpm will pass the test. But does this
makes sense on a linux system? For what is mouse_netterm useful for?

Elimar
--
Do you smell something burning or is it me?
signature.asc

Bram Moolenaar

unread,
May 4, 2019, 10:15:46 AM5/4/19
to vim...@googlegroups.com, Elimar Riesebieter, Dominique Pellé
Let me try installing libgpm-dev... Yep, then I see the test failing.

> But does this makes sense on a linux system? For what is mouse_netterm
> useful for?

We should be able to make this work. Adding gpm support should not
break any other mouse.

--
Arthur pulls Pin out. The MONK blesses the grenade as ...
ARTHUR: (quietly) One, two, five ...
GALAHAD: Three, sir!
ARTHUR: Three.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

Ralf Schandl

unread,
May 6, 2019, 6:53:34 PM5/6/19
to vim...@googlegroups.com


On 03.05.19 13:56, Elimar Riesebieter wrote:
> Hi,
>
> compiling v8.1.1250 within a remote tmux session I get:
>
> Found errors in Test_term_mouse_double_click_to_create_tab():
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=xterm2: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=xterm2: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page
> 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=sgr: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=sgr: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=urxvt: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=urxvt: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 38: ttymouse=dec: Expected 32 but got 0
> function RunTheTest[40]..Test_term_mouse_double_click_to_create_tab line 41: ttymouse=dec: Expected ['Tab page 1', ' Xtab1', 'Tab page 2', '> [No Name]', 'Tab page 3', ' Xtab2'] but got ['Tab page 1', ' Xtab1', 'Tab page 2', '> Xtab2']
> TEST FAILURE
>
>

I can confirm this. Same when building on Ubuntu 16.04. No tmux - just
plain gnome-terminal and XTerm.

Bram Moolenaar

unread,
May 7, 2019, 2:42:01 PM5/7/19
to vim...@googlegroups.com, Ralf Schandl
This should be fixed by patch 8.1.1265

--
There are only two hard things in programming: Cache invalidation,
naming things and off-by-one errors.
Reply all
Reply to author
Forward
0 new messages