[vim/vim] Fix regression 8.1.1491 (#4519)
mattn
Sorry, 8.1.1491 is not completed. Changes for misc2.c is not required. When the first command-name is quoted, system() fail. If revert change of misc2.c ("c:\go\bin\go.exe" "env" "GOPATH") succeed.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/4519
Commit Summary
- Fix regression 8.1.1491
File Changes
- M src/misc2.c (10)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
Codecov
Codecov Report
Merging #4519 into master will decrease coverage by
0.01%.
The diff coverage is100%.
@@ Coverage Diff @@ ## master #4519 +/- ## ========================================== - Coverage 80.63% 80.62% -0.02% ========================================== Files 111 111 Lines 143817 143817 ========================================== - Hits 115971 115947 -24 - Misses 27846 27870 +24
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/misc2.c | 84.09% <100%> (ø) |
⬆️ |
| src/if_xcmdsrv.c | 83.84% <0%> (-0.72%) |
⬇️ |
| src/gui_gtk_x11.c | 48.62% <0%> (-0.5%) |
⬇️ |
| src/gui_beval.c | 62.5% <0%> (-0.44%) |
⬇️ |
| src/ex_cmds.c | 82.18% <0%> (-0.25%) |
⬇️ |
| src/ex_cmds2.c | 87.94% <0%> (-0.12%) |
⬇️ |
| src/gui.c | 58.05% <0%> (-0.06%) |
⬇️ |
| src/message.c | 76.84% <0%> (ø) |
⬆️ |
| src/terminal.c | 81.05% <0%> (+0.03%) |
⬆️ |
| src/ui.c | 55.67% <0%> (+0.07%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 38ea784...66c3d8c. Read the comment docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
K.Takata
I think you are talking about 8.1.1492, not 1491.
Bram Moolenaar
I'll revert the change in misc2.c, I already wondered why it was needed.
> 66c3d8cde9541e762fc86ac1fef3a676761117d4 Skip " and ( orderly
Since we are checking if the command starts with "start", isn't it OK to
skip over all quotes and opening parens? Why only skip over "( and not
over (" ?
--
Drink wet cement and get really stoned.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Bram Moolenaar
Would it be possible to write a test for that system() command?
mattn
I'll write test in later.