[vim/vim] gvim user unable to input underscore "_" character in plugin ctrl-p's input prompt (#6243)

410 views
Skip to first unread message

kting28

unread,
Jun 11, 2020, 5:40:38 PM6/11/20
to vim/vim, Subscribed

Describe the bug
In the gvim 8.2, somewhere between patch 567 and patch 775+, something changed that broke ctrl-p's input prompt. User can type any character but underscore "_" somehow is ignored. The last known good one I tried is patch 566.

To Reproduce
Detailed steps to reproduce the behavior:
0. install ctrl-p

  1. Run gvim from patch 775+
  2. type ctrl + p
  3. Type any string of characters including underscore
  4. underscore not echo'ed back

Expected behavior
All characters should be echo'ed back on the input line. vim in console mode has no such issue. All versions <= patch 566 are ok.

Screenshots
image
Here the underscore key moves the cursor up on the "==NO ENTRIES==" line

Environment (please complete the following information):

Included patches: 1-775
Huge version with GTK2 GUI.  Features

Ubuntu 16.04

Additional context
Reported also here
ctrlpvim/ctrlp.vim#545

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

lacygoill

unread,
Jun 11, 2020, 11:17:48 PM6/11/20
to vim/vim, Subscribed

I can't reproduce on Ubuntu 16.04 with GTK2.

I tried like this:

vim -Nu NORC -g --cmd 'set rtp^=/path/to/ctrlp.vim'
" press:  C-p _
" result: the underscore is correctly inserted on the plugin's prompt

I guess something else is needed to reproduce? Maybe the plugin needs to be configured in a certain way?

kting28

unread,
Jun 12, 2020, 12:39:56 AM6/12/20
to vim/vim, Subscribed

Thanks for the response, I tried the same command above and can still reproduce the problem.
are you using latest from "https://github.com/ctrlpvim/ctrlp.vim" ?
Let me try 960 first. I think the other report on this is on 940.

lacygoill

unread,
Jun 12, 2020, 12:47:42 AM6/12/20
to vim/vim, Subscribed

Yes, I just cloned the plugin with this command in a temporary directory:

$ git clone https://github.com/ctrlpvim/ctrlp.vim

Then I added the path to the plugin in my runtimepath.
The plugin works, because when I press C-p, the prompt is displayed.

gif

kting28

unread,
Jun 12, 2020, 1:25:39 AM6/12/20
to vim/vim, Subscribed

Just tried 960, no dice, same result with the command above. What I do notice this is that the issue is not just underscore. Basically somehow all chars like $ ^ are treated like the normal mode - i.e. if I type something in the input line and type "up arrow" to the result list, $ moves the cursor to the end and ^ to the beginning.
Anyway, since you can't reproduce I will just wait to see if more people report this. Thanks again for your time.

Christian Brabandt

unread,
Jun 12, 2020, 3:36:21 AM6/12/20
to vim/vim, Subscribed

That was the gui version? Which one? Can you bisect and find the commit that caused this?

lacygoill

unread,
Jun 12, 2020, 4:04:22 AM6/12/20
to vim/vim, Subscribed

FWIW, here are all the commits whose message contains "GUI", inside the range mentioned in the OP (i.e. from 567 up to 775):

  • 8.2.0622 Haiku: GUI does not compile
  • 8.2.0630 "make tags" does not cover Haiku GUI file
  • 8.2.0646 t_Co uses the value of $COLORS in the GUI
  • 8.2.0763 GUI test fails without the terminal feature
  • 8.2.0765 In the GUI can't use all the modifiers.
  • 8.2.0770 cannot map CTRL-B when using the GUI

If I could reproduce, the first commit I would check is 8.2.0765.

Marius Gedminas

unread,
Jun 12, 2020, 5:32:07 AM6/12/20
to vim/vim, Subscribed

I can reproduce with 8.2.957, GTK3 GUI, on Ubuntu 20.04 LTS. ctrlp.vim version 1.79.

Marius Gedminas

unread,
Jun 12, 2020, 5:45:32 AM6/12/20
to vim/vim, Subscribed

git bisect tells me fd615a3 (7.0.0765) is the 1st bad commit.

It's probably relevant that _, ^ and $ require me to hold down Shift.

(A few commits are so bad I can't launch ctrlp with Ctrl+P, I have to use :CtrlP. Then Ctrl+P starts working, but _ doesn't.)

lacygoill

unread,
Jun 20, 2020, 8:54:20 AM6/20/20
to vim/vim, Subscribed

For those of you who can reproduce, can you check whether ef6746f helped in any way?

Marius Gedminas

unread,
Jun 22, 2020, 7:46:52 AM6/22/20
to vim/vim, Subscribed

I haven't checked 8.2.1019 specifically, but the current git master (8.2.1034) works fine: I can enter _ and ^ into the ctrlp.vim plugin after launching the GUI with vim -g.

lacygoill

unread,
Jun 22, 2020, 7:50:30 AM6/22/20
to vim/vim, Subscribed

The only commits whose message contains "GUI" after 8.2.0960 are:

  • 8.2.1019 mapping <M-S-a> does not work in the GUI
  • 8.2.1020 popupwin test fails in the GUI
  • 8.2.1027 GUI: multi-byte characters do not work in a terminal

So, if the issue is fixed, it's probably due to one of these.

Christian Brabandt

unread,
Jun 22, 2020, 7:51:01 AM6/22/20
to vim/vim, Subscribed

closing then.

Christian Brabandt

unread,
Jun 22, 2020, 7:51:04 AM6/22/20
to vim/vim, Subscribed

Closed #6243.

sanjaypatelic

unread,
Jul 30, 2020, 2:28:54 PM7/30/20
to vim/vim, Subscribed

I noticed that the issue can be fixed by setting g:ctrlp_key_loop=1 to enable multi byte characters.
However, it will take away g:ctrlp_lazy_update from you!!

Reply all
Reply to author
Forward
0 new messages