[vim/vim] gtk GUI: Fix Ctrl+[ (Belgian,German keyb. layout) (PR #10658)
haron13-2019
Problem: issue #10454 reported troubles with leaving insert mode on Belgian keyboard in GTK GUI. Handling of Ctrl+ü on German keyboard is lost over the time as well in GTK GUI.
This PR partly fixes issue #10454 (only GTK part of it, not Win32). Additionally it provides back missing Ctrl+ü handling on German keyboard (ü is on same place in german layout where [ is on english keyboard). Fix is probably not very nice and cannot be yet considered a final solution (?) but it seems to work. It was made possible due to the fact that Motif GUI still handles both Belgian and German CTRL+[ nicely. Tracing/comparing of the key codes feed to background Vim engine by Motif GUI and by GTK GUI via add_to_input_buf() was the key.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10658
Commit Summary
- 9ad7ca2 gtk GUI: Fix Ctrl+[ (Belgian,German keyb. layout)
File Changes
(1 file)
- M src/gui_gtk_x11.c (26)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10658 (9ad7ca2) into master (7fe956d) will increase coverage by
0.88%.
The diff coverage is0.00%.
@@ Coverage Diff @@ ## master #10658 +/- ## ========================================== + Coverage 81.71% 82.60% +0.88% ========================================== Files 158 148 -10 Lines 185503 172864 -12639 Branches 41959 39084 -2875 ========================================== - Hits 151586 142796 -8790 + Misses 21451 17472 -3979 - Partials 12466 12596 +130
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.60% <0.00%> (-0.01%) |
⬇️ |
| linux | 82.60% <0.00%> (-0.01%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/gui_gtk_x11.c | 51.81% <0.00%> (-0.40%) |
⬇️ |
| src/highlight.c | 78.41% <0.00%> (-2.69%) |
⬇️ |
| src/time.c | 87.08% <0.00%> (-2.56%) |
⬇️ |
| src/misc2.c | 86.68% <0.00%> (-2.52%) |
⬇️ |
| src/help.c | 80.07% <0.00%> (-2.38%) |
⬇️ |
| src/buffer.c | 84.11% <0.00%> (-2.35%) |
⬇️ |
| src/session.c | 63.15% <0.00%> (-1.94%) |
⬇️ |
| src/gui.c | 71.19% <0.00%> (-1.87%) |
⬇️ |
| src/menu.c | 81.36% <0.00%> (-1.83%) |
⬇️ |
| src/arglist.c | 83.83% <0.00%> (-1.72%) |
⬇️ |
| ... and 128 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7fe956d...9ad7ca2. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Vivian De Smedt
I have tested release 9.00.35 and build release 9.00.48 and I still have the problem.
I'm afraid the patch doesn't solves the problem and issue should be reopen.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Anton Sharonov
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/10658/c1179546260%40github.com.
vim-dev ML
Did you made your tests on Linux or on windows, because my patch is only
for unix-like GTK gvim. What does your :version command in gvim reports?
(Windows version of the patch is in pipeline yet ))))
15:34:
> I have tested release 9.00.35 and build release 9.00.48 and I still have
> the problem.
> I'm afraid the patch doesn't solves the problem and issue should be reopen.
>
> —
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/10658/c1179546260%40github.com
> .
>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Vivian De Smedt
Hi Vim,
I do my test on Windows 10 on Vim version 9.00.48.
Best regards,
Vivian.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
haron13-2019
Hi Vivian,
Just created a PR #10687 which hopefully solves your issue on windows.
If you can build your own windows binary you can try my branch directly:
https://github.com/haron13-2019/vim/tree/azerty_ctrl_dead
With best regards, Anton
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Vivian De Smedt
Hi Anton,
Thanks for the branch (https://github.com/haron13-2019/vim.git).
I only realize that you wrote to me few minutes ago (sorry for that).
I have tested your branch but unfortunately it doesn't solve my problem.
Best regards,
Vivian.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.