[vim/vim] GTK3, XIM: make it possible to specify a decimal number like 10.5 (PR #20316)

[MURAOKA Taro]

for the font size in preedit window, for GTK3.16 and later

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20316

Commit Summary

• 35ea3f7 Make it possible to specify a decimal number like 10.5 for the font size in preedit window, for GTK3.16 and later

File Changes

(1 file)

• M src/gui_xim.c (8)

Patch Links:

• https://github.com/vim/vim/pull/20316.patch
• https://github.com/vim/vim/pull/20316.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20316@github.com>

[Christian Brabandt]

@chrisbra commented on this pull request.

---

In src/gui_xim.c:

> @@ -488,7 +490,7 @@ im_preedit_window_open(void)
 	    fontsize = dpi * fontsize / 72;
 	}
 	if (fontsize > 0)
-	    fontsize_propval = g_strdup_printf("%dpx", fontsize);
+	    fontsize_propval = g_strdup_printf("%dpx", (gint)fontsize);

Hm,
should that rather be:

⬇️ Suggested change

-	    fontsize_propval = g_strdup_printf("%dpx", (gint)fontsize);
+	    fontsize_propval = g_strdup_printf("%dpx", (gint)(fontsize + 0.5));

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20316/review/4353152805@github.com>

[MURAOKA Taro]

@koron pushed 1 commit.

• a5f5ab0 Update src/gui_xim.c

—
View it on GitHub or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20316/before/35ea3f76e3a46bfe02c88c52cdf8b8bd88ea1770/after/a5f5ab03c10382428f4ff4b484a2a463d4b68053@github.com>

[MURAOKA Taro]

@koron commented on this pull request.

---

In src/gui_xim.c:

> @@ -488,7 +490,7 @@ im_preedit_window_open(void)
 	    fontsize = dpi * fontsize / 72;
 	}
 	if (fontsize > 0)
-	    fontsize_propval = g_strdup_printf("%dpx", fontsize);
+	    fontsize_propval = g_strdup_printf("%dpx", (gint)fontsize);

@chrisbra Thank you.

I merged your suggestion as is. a5f5ab0
After merging, I checked it in my local environment and it worked without any problems.

Please review it again.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20316/review/4353836567@github.com>