[vim/vim] patch 9.2.XXXX: tests: test_edit_ctrl_r_failed() is flaky (PR #20050)
Christian Brabandt
Problem: tests: test_edit_ctrl_r_failed() is flaky
Solution: Add WaitForAssert() call to wait for the error message
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20050
Commit Summary
- a3db273 patch 9.2.XXXX: tests: test_edit_ctrl_r_failed() is flaky
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 8 commits.
- 0121fef tests: Test_visual_starts_before_skipcol is flaky
- 8933d3b tests: Test_display_scroll_update_visual is flaky
- c083446 tests: Test_hlsearch_and_visual is flaky
- f0a671a tests: Test_search_stat_and_incsearch is flaky
- 9de93b4 tests: Test_tabpanel_visual is flaky
- fc42b64 tests: Test_visual_block_with_virtualedit is flaky
- 178e22c tests: Test_visual_sbr is flaky
- 9a53fbb tests: Test_entering_digraph is flaky
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
D. Ben Knoble
benknoble left a comment (vim/vim#20050)Hm. Ignoring Test_wildmenu_pum, which seems to be consistently failing on my system, here's a bisect log of the failures I saw (usually ~2 or 3, but I have huge with no GUI for tests for… reasons).
# bad: [0f9218851dc91a855c3d186ccd05f550907cf37e] translation(ru): Fix typo in "може" to "можете" in lang/README.ru.txt
# good: [4c287947164fe26a6bd32e1c9362668388ae7457] patch 9.2.0350: Enabling modelines poses a risk
git bisect start '0f9218851dc91a855c3d186ccd05f550907cf37e' '4c287947164fe26a6bd32e1c9362668388ae7457'
# good: [237d77e07ca79f29d724a4ad74bdfd5eca830394] patch 9.2.0366: pum: flicker when updating pum in place
git bisect good 237d77e07ca79f29d724a4ad74bdfd5eca830394
# good: [fe3c27ce0b7b889a2ae29833cae55ca92ae86518] patch 9.2.0379: gui.color_approx is never used
git bisect good fe3c27ce0b7b889a2ae29833cae55ca92ae86518
# good: [4c287947164fe26a6bd32e1c9362668388ae7457] patch 9.2.0350: Enabling modelines poses a risk
git bisect good 4c287947164fe26a6bd32e1c9362668388ae7457
# good: [4c287947164fe26a6bd32e1c9362668388ae7457] patch 9.2.0350: Enabling modelines poses a risk
git bisect good 4c287947164fe26a6bd32e1c9362668388ae7457
# good: [3918f3232f874b3c96f8bfccc5049711f16c252e] runtime(doc): fix incorrect description of 'scrolloffpad'
git bisect good 3918f3232f874b3c96f8bfccc5049711f16c252e
# good: [cee8fd73eb54a3196ac3cc2292a0e6910aeaff75] patch 9.2.0387: DECRQM request may leave stray chars in terminal
git bisect good cee8fd73eb54a3196ac3cc2292a0e6910aeaff75
# bad: [44f707da6a06b8310bfe23f5477c7653215e1230] patch 9.2.0389: DECRQM still leaves stray "pp" on Apple Terminal.app
git bisect bad 44f707da6a06b8310bfe23f5477c7653215e1230
# good: [f194676c936d9f3a8479a72afbbe9f244039e27e] patch 9.2.0388: strange indent in update_topline()
git bisect good f194676c936d9f3a8479a72afbbe9f244039e27e
# first bad commit: [44f707da6a06b8310bfe23f5477c7653215e1230] patch 9.2.0389: DECRQM still leaves stray "pp" on Apple Terminal.app
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20050)And what is the failure message? I suppose this happens on Apple Terminal?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- e0e55ac tests: Test_visual_block_scroll is flaky
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- 395a47a fixup: add term_wait to test_search_stat
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- a3e8b7c fixup: add TermWait to test_search
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
D. Ben Knoble
benknoble left a comment (vim/vim#20050)This is the same system as reported in #20041: I get
Found errors in Test_wildmenu_pum():
Run 1, 18:40:11 - 18:40:17 in 5.482192 seconds:
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
Run 2, 18:40:19 - 18:40:24 in 5.523757 seconds:
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
Run 3, 18:40:28 - 18:40:34 in 5.562882 seconds:
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
Run 4, 18:40:40 - 18:40:46 in 5.561199 seconds:
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
Run 5, 18:40:54 - 18:40:59 in 5.555439 seconds:
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
which is probably not particularly helpful. In the actual test log, it says
Executed Test_wildmenu_pum() in 5.481781 seconds
Found swap files: ['./.bar.swp']
Found errors in Test_wildmenu_pum():
Caught exception in Test_wildmenu_pum(): WaitFor() timed out after 5000 msec @ command line..script /home/benknoble/code/vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_wildmenu_pum[281]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
Flaky test failed, running it again
with of course its multiple runs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20050)Hm, can you comment out this line here:
re-run the test and share the failing screendump with me?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20050)oh and does the test work again when you test on this PR: #20045 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.