[vim/vim] syntax(i3config+swayconfig): separate identifier highlight groups + cleanup of output options (PR #18851)

Josef Litoš

unread,

Dec 2, 2025, 3:21:48 PM (15 hours ago) Dec 2

to vim/vim, Subscribed

cleanup of PR for tearing (#18293) and cleanup of other output options
- removed allow_tearing from global keywords (it's only an output option)
- moved ...clockwise directives from general to transform options
- separated icc highlight to correctly detect and highlight paths
- updated output bg to use the same approach as icc for file path highlighting
updated all identifier-matchers to the same design
- complex ("string") or referenced ($var) identifiers always included
  - extend fixes string matches to recognize there was some text already matched (otherwise errors as it thinks it was an empty space)
  - string matches skip spaces first and thereby extend the match over spaces - we can drop space parsing from the identifier match itself
- one-word identifiers get highlighted with the respective identifier highlight group
  - therefore OutputIdent mostly removed since it was misused for setting the highlight, not parsing
- all identifiers now stop before the ,; command separators
added support for bar identifiers in swayconfig (and supporting bar matcher restructure in i3config)
- separate fonts group now added to the block top-down-style; no containedin
- updated implementation of #18814
separated input type and device name highlights
added missing highlight defaults for mark options
removed extend from block commands that cannot be in another block

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18851

Commit Summary

8c75b4b syntax(i3config): highlight identifiers separately
bb3c94b syntax(swayconfig): separate identifier groups + cleanup

File Changes

(2 files)

M runtime/syntax/i3config.vim (38)
M runtime/syntax/swayconfig.vim (57)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Quentin Hibon

unread,

Dec 2, 2025, 4:23:39 PM (14 hours ago) Dec 2

to vim/vim, Subscribed

hiqua left a comment (vim/vim#18851)

I'll review it later this week, but in the meantime @litoj would you consider becoming the official maintainer instead of me for the i3 files? I only volunteered because no one else did, but if you're active and even creating PRs, it might make sense, if you're interested.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Josef Litoš

unread,

Dec 2, 2025, 4:27:45 PM (14 hours ago) Dec 2

to vim/vim, Subscribed

litoj left a comment (vim/vim#18851)

would you consider becoming the official maintainer instead of me for the i3 files?

@hiqua I'd love to, though I'm unsure what the process for that is.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Quentin Hibon

unread,

Dec 2, 2025, 7:21:46 PM (11 hours ago) Dec 2

to vim/vim, Subscribed

hiqua left a comment (vim/vim#18851)

I'd assume it's as simple as replacing my username with yours at the top of the file!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Josef Litoš

unread,

3:55 AM (3 hours ago) 3:55 AM

to vim/vim, Push

@litoj pushed 1 commit.

63f45f3 Update maintainer information in i3config.vim

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward